fix: restore attrs del functionality #2908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
reviewed
Mar 15, 2025
tests/test_attributes.py
Outdated
|
|
||
| def test_del_works() -> None: | ||
| store = zarr.storage.MemoryStore() | ||
| z = zarr.create(10, store=store, overwrite=True) |
There was a problem hiding this comment.
Please change this to create_array or create_group.
There was a problem hiding this comment.
used parametrize to test both.
jhamman
reviewed
Mar 15, 2025
jhamman
approved these changes
Mar 17, 2025
dcherian
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the bevahior of
del obj.attrs['some-key']to the pre #2870 behaviorFixes: #2903
TODO:
changes/