8000 Add shards to array strategy by dcherian · Pull Request #2822 · zarr-developers/zarr-python · GitHub
[go: up one dir, main page]
Skip to content

Add shards to array strategy #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 14, 2025
Merged

Add shards to array strategy #2822

merged 4 commits into from
Feb 14, 2025

Conversation

dcherian
Copy link
Contributor
@dcherian dcherian commented Feb 12, 2025 •
edited
Loading

Adds shards strategy and uses it in the arrays strategy

This does catch #2816 and needs #2817 to be merged to pass.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Feb 12, 2025
@dcherian dcherian mentioned this pull request Feb 12, 2025
Merged
6 tasks
@dcherian dcherian force-pushed the codecs-in-property-tests branch 2 times, most recently from 566e524 to 29460a7 Compare February 12, 2025 21:39
@TomNicholas TomNicholas mentioned this pull request Feb 13, 2025
Merged
12 tasks
@dcherian dcherian force-pushed the codecs-in-property-tests branch from 8ebb46b to fb22082 Compare February 13, 2025 15:18
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Feb 13, 2025
@dcherian dcherian force-pushed the codecs-in-property-tests branch from fb22082 to e3ad220 Compare February 13, 2025 15:19
@dcherian dcherian changed the title Add codecs, shards to array strategy Add shards to array strategy Feb 13, 2025
@dcherian dcherian marked this pull request as ready for review February 13, 2025 15:20
@d-v-b d-v-b enabled auto-merge (squash) February 14, 2025 15:32
@dcherian dcherian requested a review from d-v-b February 14, 2025 15:50
@d-v-b d-v-b merged commit 3c25dac into zarr-developers:main Feb 14, 2025
30 checks passed
@dcherian dcherian deleted the codecs-in-property-tests branch February 14, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcherian @d-v-b
0