8000 Align lines for improved rendering by rtobar · Pull Request #2648 · zarr-developers/zarr-python · GitHub
[go: up one dir, main page]
Skip to content

Align lines for improved rendering #2648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2025
Merged

Align lines for improved rendering #2648

merged 1 commit into from
Jan 4, 2025

Conversation

rtobar
Copy link
Contributor
@rtobar rtobar commented Jan 4, 2025

These are currently misaligned in the source, which is probably why it's funnily rendered.

Screenshot_20250105-044024

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@rtobar
Align lines for improved rendering
a7b3dce 
These are currently misaligned in the source, which is probably why it's funnily rendered.
jhamman
jhamman approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member
@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rtobar!

@jhamman jhamman merged commit 0adcbe7 into zarr-developers:main Jan 4, 2025
23 checks passed
@rtobar rtobar deleted the patch-1 branch January 5, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtobar @jhamman
0