8000 Add FSStore contiguous bug fix note by jakirkham · Pull Request #1325 · zarr-developers/zarr-python · GitHub
[go: up one dir, main page]
Skip to content

Add FSStore contiguous bug fix note #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2023
Merged

Add FSStore contiguous bug fix note #1325

merged 4 commits into from
Jan 20, 2023

Conversation

jakirkham
Copy link
Member

Also tidy release notes

xref: #1285 (comment)

cc @joshmoore @madsbk

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jakirkham
Add FSStore contiguous bug fix note
6e1a5e2 
Also tidy release notes
@jakirkham jakirkham mentioned this pull request Jan 19, 2023
Merged
5 tasks
@joshmoore
Copy link
Member

Thanks, @jakirkham! 🙏🏽 but the format looks a bit borked:

Screenshot 2023-01-19 at 20 36 44

@jakirkham
Copy link
Member Author

Unfortunately that entry already has issues

Tried to fix some of them, but can back them out if that is distracting (it is tangential to this PR)

Screen Shot 2023-01-19 at 11 41 46 AM

jakirkham
jakirkham commented Jan 19, 2023
View reviewed changes
jakirkham
jakirkham commented Jan 19, 2023
View reviewed changes
@joshmoore
Copy link
Member

Unfortunately that entry already has issues

Sorry. I just saw that myself. Didn't mean to offload it on you.

jakirkham
jakirkham commented Jan 19, 2023
View reviewed changes
docs/release.rst Outdated
Comment on lines 25 to 27
- storage transformers

- ``get_partial_values`` and ``set_partial_values``
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this looks ok in reStructuredText, but Sphinx seems to render it wacky. In any event at least this is consistent with what we do elsewhere

@jakirkham
Copy link
Member Author

This is probably as good as we can get

Screen Shot 2023-01-19 at 12 39 14 PM

https://zarr--1325.org.readthedocs.build/en/1325/release.html

@jakirkham jakirkham requested a review from joshmoore January 19, 2023 20:53
@jakirkham
Copy link
Member Author

@joshmoore, could you please review when you have a chance?

@joshmoore
Copy link
Member

Screenshot 2023-01-20 at 12 13 37

Going to call this good. Merging. (@jstriebel can hit us on the head if he wants)

@jakirkham jakirkham merged commit 1793da0 into zarr-developers:main Jan 20, 2023
@jakirkham jakirkham deleted the rel_note_fs_bytes branch January 20, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmoore joshmoore Awaiting requested review from joshmoore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakirkham @joshmoore
0