Refactor codebase to support a new simplified Parser->ManifestStore model. #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…s://github.com/TomNicholas/VirtualiZarr into refactor-kerchunk-readers-to-use-ManifestStore
Co-authored-by: Raphael Hagen <norlandrhagen@gmail.com>
Co-authored-by: Raphael Hagen <norlandrhagen@gmail.com>
Co-authored-by: Raphael Hagen <norlandrhagen@gmail.com>
Co-authored-by: Raphael Hagen <norlandrhagen@gmail.com>
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
|
@maxrjones I think this is ready to merge 🙀 😆 . Do you want to do the honors? |
Changes have already been incorporated.
Co-authored-by: Raphael Hagen <norlandrhagen@gmail.com>
Co-authored-by: Tom Nicholas <tom@earthmover.io>
This was referenced Jun 16, 2025
This was referenced Jun 17, 2025
12 tasks
TomNicholas
added a commit
that referenced
this pull request
Jun 25, 2025
* move Parser definition to new parser.typing module * add API docs for Parser protocol and parser classes * avoid extra .hdf namespace for only one parser * rename reader -> parser * update custom parsers page * update usage docs * update roadmap to reflect where we actually are * update faq * note about the renaming of readers->parsers * minor qualification * release notes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change import * ignore lint * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Nits from Chunk's review Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com> * add note about using context managers * Add context manager for assertion Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com> * fix nav * remove sphinx-style page link * syntax for note * correct link syntax * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * can't link to private zarr metadata class * can't link to private zarr metadata class * try following syntax for nested lists given here https://squidfunk.github.io/mkdocs-material/reference/lists/#using-ordered-lists --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fragility of url auto-parsing logic #561
Function definition for
open_virtual_datasetin next major release #553Redefine Virtual Readers as
func(filepath) -> ManifestStore#498Should we try to use Obstore for reading files? #476
Support passing configuration options to default_object_store #559
docs/releases.rstapi.rst