E5E9 Fix error lines extraction & Fix testcases by moreal · Pull Request #10 · youknowone/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Fix error lines extraction & Fix testcases #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Jan 19, 2026
Merged

Fix error lines extraction & Fix testcases #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce0b7f0
Fix error lines extraction
moreal Jan 19, 2026
8773d95
Correct testcase
moreal Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/update_lib/auto_mark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def _parse_error_details(test_results: TestResult, lines: list[str]) -> None:
# Collect lines until the next separator or end
while i < len(lines):
current = lines[i]
if current.startswith("====="):
if current.startswith("=====") or current.startswith("-----"):
break
error_lines.append(current)
i += 1
Expand Down
32 changes: 16 additions & 16 deletions scripts/update_lib/tests/test_auto_mark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,20 +32,20 @@ def test_parse_failing_test(self):
"""Test parsing a failing test."""
stdout = """
Run 1 tests sequentially
test_foo (test.test_example.TestClass) ... FAIL
test_foo (test.test_example.TestClass.test_foo) ... FAIL
-----------
"""
result = parse_results(self._make_result(stdout))
self.assertEqual(len(result.tests), 1)
self.assertEqual(result.tests[0].name, "test_foo")
self.assertEqual(result.tests[0].path, "test.test_example.TestClass")
self.assertEqual(result.tests[0].path, "test.test_example.TestClass.test_foo")
self.assertEqual(result.tests[0].result, "fail")

def test_parse_error_test(self):
"""Test parsing an error test."""
stdout = """
Run 1 tests sequentially
test_bar (test.test_example.TestClass) ... ERROR
test_bar (test.test_example.TestClass.test_bar) ... ERROR
-----------
"""
result = parse_results(self._make_result(stdout))
Expand All @@ -56,7 +56,7 @@ def test_parse_ok_test_ignored(self):
"""Test that passing tests are ignored."""
stdout = """
Run 1 tests sequentially
test_foo (test.test_example.TestClass) ... ok
test_foo (test.test_example.TestClass.test_foo) ... ok
-----------
"""
result = parse_results(self._make_result(stdout))
Expand All @@ -66,15 +66,15 @@ def test_parse_un FF44 expected_success(self):
"""Test parsing unexpected success."""
stdout = """
Run 1 tests sequentially
test_foo (test.test_example.TestClass) ... unexpected success
test_foo (test.test_example.TestClass.test_foo) ... unexpected success
-----------
UNEXPECTED SUCCESS: test_foo (test.test_example.TestClass)
UNEXPECTED SUCCESS: test_foo (test.test_example.TestClass.test_foo)
"""
result = parse_results(self._make_result(stdout))
self.assertEqual(len(result.unexpected_successes), 1)
self.assertEqual(result.unexpected_successes[0].name, "test_foo")
self.assertEqual(
result.unexpected_successes[0].path, "test.test_example.TestClass"
result.unexpected_successes[0].path, "test.test_example.TestClass.test_foo"
)

def test_parse_tests_result(self):
Expand All @@ -89,9 +89,9 @@ def test_parse_multiple_tests(self):
"""Test parsing multiple test results."""
stdout = """
Run 3 tests sequentially
test_one (test.test_example.TestA) ... FAIL
test_two (test.test_example.TestA) ... ok
test_three (test.test_example.TestB) ... ERROR
test_one (test.test_example.TestA.test_one) ... FAIL
test_two (test.test_example.TestA.test_two) ... ok
test_three (test.test_example.TestB.test_three) ... ERROR
-----------
"""
result = parse_results(self._make_result(stdout))
Expand All @@ -101,10 +101,10 @@ def test_parse_error_message(self):
"""Test parsing error message from traceback."""
stdout = """
Run 1 tests sequentially
test_foo (test.test_example.TestClass) ... FAIL
test_foo (test.test_example.TestClass.test_foo) ... FAIL
-----------
======================================================================
FAIL: test_foo (test.test_example.TestClass)
FAIL: test_foo (test.test_example.TestClass.test_foo)
----------------------------------------------------------------------
Traceback (most recent call last):
File "test.py", line 10, in test_foo
Expand All @@ -121,19 +121,19 @@ def test_parse_multiple_error_messages(self):
"""Test parsing multiple error messages."""
stdout = """
Run 2 tests sequentially
test_foo (test.test_example.TestClass) ... FAIL
test_bar (test.test_example.TestClass) ... ERROR
test_foo (test.test_example.TestClass.test_foo) ... FAIL
test_bar (test.test_example.TestClass.test_bar) ... ERROR
-----------
======================================================================
FAIL: test_foo (test.test_example.TestClass)
FAIL: test_foo (test.test_example.TestClass.test_foo)
----------------------------------------------------------------------
Traceback (most recent call last):
File "test.py", line 10, in test_foo
self.assertEqual(1, 2)
AssertionError: 1 != 2

======================================================================
ERROR: test_bar (test.test_example.TestClass)
ERROR: test_bar (test.test_example.TestClass.test_bar)
----------------------------------------------------------------------
Traceback (most recent call last):
File "test.py", line 20, in test_bar
Expand Down
0