8000 Add `.gitattributes` by klimov-paul · Pull Request #87 · yoanm/symfony-jsonrpc-http-server · GitHub
[go: up one dir, main page]
Skip to content

Add .gitattributes #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2023
Merged

Add .gitattributes #87

merged 3 commits into from
Apr 1, 2023

Conversation

klimov-paul
Copy link
Contributor

Add .gitattributes with export-ignore directive.
This allows to minimize the size of the future release tags.

@klimov-paul klimov-paul requested a review from yoanm as a code owner March 23, 2023 14:35
@codecov
Copy link
codecov bot commented Mar 26, 2023 •
edited
Loading

Codecov Report

Merging #87 (6ec1e0e) into master (4d449da) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master       #87   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        41        41           
===========================================
  Files              7         7           
  Lines            163       163           
===========================================
  Hits             163       163
Flag Coverage Δ
functional-tests 100.00% <ø> (ø)
php-8.1 100.00% <ø> (ø)
sf-4.4 100.00% <ø> (ø)
sf-5.4 100.00% <ø> (ø)
unit-tests 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yoanm
Copy link
Owner
yoanm commented Mar 26, 2023

Hello 👋

First, thanks for the improvement 👌
Unfortunately, it seems there is an issue with codacy preventing the CI to be green ... Despite a fix attempt on master, the error is still there on that PR and I didn't succeed to figure out why exactly.
I most likely won't have time to check it during the week, I'll take another look next week-end.
I'll try to take a look at your other PRs meanwhile

@yoanm
Copy link
Owner
yoanm commented Apr 1, 2023

I don't get it, it works on #89 but not there 🤔
Lonely reason I see is the fact that this PR is from a fork and not the other (but even if it's that, error doesn't make any sense anyway).

@yoanm yoanm force-pushed the add-gitattributes branch 4 times, most recently from 0d2371c to 7de3cd6 Compare April 1, 2023 14:47
@yoanm yoanm force-pushed the add-gitattributes branch from 7de3cd6 to 6ec1e0e Compare April 1, 2023 14:49
@yoanm yoanm merged commit db35271 into yoanm:master Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoanm yoanm Awaiting requested review from yoanm yoanm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klimov-paul @yoanm
0