8000 Allow Symfony 6 by tourze · Pull Request #84 · yoanm/symfony-jsonrpc-http-server · GitHub
[go: up one dir, main page]
Skip to content

Allow Symfony 6 #84

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow Symfony 6 #84

wants to merge 1 commit into from

Conversation

tourze
Copy link
@tourze tourze commented Jul 2, 2022

No description provided.

@tourze tourze requested a review from yoanm as a code owner July 2, 2022 11:16
@yoanm
Copy link
Owner
yoanm commented Jul 2, 2022

Hello 👋

Thanks for the PR, as you can see on scrutinizer, code is broken due to some typehint added with Symfony 6.
You should be able to run tests locally (let me know if not) in order to fix FTs/UTs.

FYI, there is another PR related to Symfony 6

@yoanm yoanm linked an issue Jul 2, 2022 that may be closed by this pull request
Symfony 6 #85
Closed
@yoanm
Copy link
Owner
yoanm commented Apr 1, 2023

Superseded by #91

@yoanm yoanm closed this Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoanm yoanm Awaiting requested review from yoanm yoanm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symfony 6
2 participants
@tourze @yoanm
0