yoanm · yoanm · Mar 31, 2024 · Mar 31, 2024 · Mar 31, 2024
@@ -5,6 +5,14 @@ on: # Build any PRs and main branch changes
     types:
       - opened
       - synchronize
+    paths-ignore:
+      # In case of updates to those workflows, they must be pre-checked by `pre-check-CI-updates.yml` rather than this workflow !
+      # Any updates on those workflows are expected to be restricted to those workflows only ! (no update on code for instance)
+      - '.github/workflows/pre-check-CI-updates.yml'
+      - '.github/workflows/CI.yml'
+      - '.github/workflows/coverage-upload.yml'
+      - '.github/workflows/reusable-CI-workflow.yml'
+      - '.github/workflows/reusable-coverage-upload-workflow.yml'
   push:
     branches: [ master ]
   schedule:
@@ -14,210 +22,9 @@ concurrency:
   group: "${{ github.workflow }}-${{ github.head_ref || github.ref }}"
   cancel-in-progress: true
 
-env:
-  TEST_OUTPUT_STYLE: pretty
-  COMPOSER_OPTIONS: --optimize-autoloader
-
 jobs:
   tests:
-        name: UTs & FTs - Symfony ${{ matrix.symfony-version }}
-    runs-on: ubuntu-latest
-    env:
-      COVERAGE_TYPE: none
-    strategy:
-      fail-fast: true
-      max-parallel: 4
-      matrix:
-        include:
-          # Bare minimum => Lowest versions allowed by composer config
-          - symfony-version: '4.4'
-            php-version: '8.0'
-            composer-flag: --prefer-lowest
-          # Up to date versions => Latest versions allowed by composer config
-          - symfony-version: '5.4'
-            php-version: '8.2'
-          # Late symfony migration => Lowest symfony version with latest minor php version allowed by composer config
-          - symfony-version: '4.4'
-            php-version: '8.2'
-            composer-flag: --prefer-lowest
-          # Late php migration => Latest symfony version with lowest minor php version allowed by composer config
-          - symfony-version: '5.4'
-            php-version: '8.0'
-          # Symfony 6.0 latest
-          - symfony-version: '6.0'
-            php-version: '8.2'
-          # Symfony 6.0 lowest
-          - symfony-version: '6.0'
-            php-version: '8.0'
-            composer-flag: --prefer-lowest
-    steps:
-      - name: Check out code
-        uses: actions/checkout@v4
-
-      - name: Enable coverage
-        if: ${{ matrix.php-version == '8.2' }}
-        run: |
-          echo "COVERAGE_OUTPUT_STYLE=clover" >> $GITHUB_ENV
-          echo "COVERAGE_TYPE=xdebug" >> $GITHUB_ENV
-
-      - name: Setup PHP ${{ matrix.php-version }}
-        uses: shivammathur/setup-php@v2
-        env:
-          update: true # Always use latest available patch for the version
-          fail-fast: true # step will fail if an extension or tool fails to set up
-        with:
-          php-version: '${{ matrix.php-version }}'
-          tools: composer
-          coverage: ${{ env.COVERAGE_TYPE }}
-
-      - name: Setup cache
-        id: cache
-        uses: actions/cache@v4
-        with:
-          path: |
-            ~/.composer
-            ./vendor
-          # Clear the cache if composer json (as composer.lock is in the repo) has been updated
-          key: tests-${{ matrix.php-version }}-${{ matrix.symfony-version
10000
 }}-${{ matrix.composer-flag }}-${{ hashFiles('composer.json') }}
-
-      - name: Build
-        run: |
-          SF_VERSION=${{ matrix.symfony-version }}
-          # Issue with ParamterBag below 4.4.30 => https://github.com/symfony/symfony/commit/3eca446b21607ea1c7a865ece2dd8254c33679cc
-          test '${{ matrix.symfony-version }}' = '4.4' && test '${{ matrix.php-version }}' = '8.2' && SF_VERSION=4.4.30
-          composer require -W ${{ env.COMPOSER_OPTIONS }} ${{ matrix.composer-flag }} \
-            symfony/validator:^$SF_VERSION \
-          && composer update ${{ env.COMPOSER_OPTIONS }} ${{ matrix.composer-flag }} \
-          && make build
-
-      - name: Tests
-        run: make test-unit && make test-functional
-
-      - name: Create "unit tests" reports group
-        if: ${{ env.COVERAGE_TYPE == 'xdebug' }}
-        id: unit-tests-coverage-group
-        uses: yoanm/temp-reports-group-workspace/.github/actions/create-action@develop
-        with:
-          name: unit-tests
-          format: clover
-          files: build/coverage-phpunit/unit.clover
-          flags: |
-            unit-tests
-            php-${{ matrix.php-version }}
-            sf-${{ matrix.symfony-version }}
-          path: build/coverage-groups
-
-      - name: Create "functional tests" coverage group
-        if: ${{ env.COVERAGE_TYPE == 'xdebug' }}
-        id: functional-tests-coverage-group
-        uses: yoanm/temp-reports-group-workspace/.github/actions/create-action@develop
-        with:
-          name: functional-tests
-          format: clover
-          files: |
-            build/coverage-phpunit/functional.clover
-            build/coverage-behat/clover.xml
-          flags: |
-            functional-tests
-            php-${{ matrix.php-version }}
-            sf-${{ matrix.symfony-version }}
-          path: build/coverage-groups
-
-      - name: Upload coverage reports
-        if: ${{ env.COVERAGE_TYPE == 'xdebug' }}
-        uses: actions/upload-artifact@v4
-        with:
-          name: coverage-groups-php${{ matrix.php-version }}-sf${{ matrix.symfony-version }}
-          path: build/coverage-groups
-          if-no-files-found: error
-
-  static-checks:
-    name: Static checks
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Setup PHP 8.2
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: 8.2 # Latest supported
-          tools: composer
-          coverage: none
-        env:
-          # Always use latest available patch for the version
-          update: true
-
-      - name: Setup cache
-        id: cache
-        uses: actions/cache@v4
-        with:
-          path: |
-            ~/.composer
-          # Clear the cache if composer json (as composer.lock is in the repo) has been updated
-          key: tests-${{ env.PHP_VERSION }}-${{ hashFiles('composer.json') }}
-
-      - name: Build
-        run: make build
-
-      - name: ComposerRequireChecker
-        uses: docker://webfactory/composer-require-checker:4.5.0
-
-      - name: Dependencies check
-        if: ${{ github.event_name == 'pull_request' }}
-        uses: actions/dependency-review-action@v4
-
-  nightly-tests:
-    name: Nightly - Symfony ${{ matrix.symfony-version }}
-    runs-on: ubuntu-latest
-    env:
-      COMPOSER_OPTIONS: '--optimize-autoloader --ignore-platform-req=php+'
-    continue-on-error: true
-    needs: [ static-checks, tests ]
-    strategy:
-      fail-fast: false
-      max-parallel: 4
-      matrix:
-        php-version:
-          - '8.3' # Current php dev version
-        symfony-version:
-          - '4.4' # Lowest LTS
-          - '5.4' # Latest LTS
-          - '6.0' # Current major version
-        include:
-          - symfony-version: '6.3' # Next symfony minor version to manage with latest supported PHP version
-            php-version: '8.2'
-
-    steps:
-      - name: Check out code
-        uses: actions/checkout@v4
-
-      - name: Setup PHP ${{ matrix.php-version }}
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: '${{ matrix.php-version }}'
-          coverage: none
-        env:
-          # Always use latest available patch for the version
-          update: true
-
-      - name: Setup cache
-        id: cache
-        uses: actions/cache@v4
-        with:
-          path: |
-            ~/.composer
-            ./vendor
-          # Clear the cache if composer json (as composer.lock is in the repo) has been updated
-          key: tests-${{ matrix.php-version }}-${{ matrix.symfony-version }}-${{ hashFiles('composer.json') }}
-
-      - name: Build
-        run: |
-          composer config minimum-stability dev \
-          && composer require -W ${{ env.COMPOSER_OPTIONS }} \
-            symfony/validator:^${{ matrix.symfony-version }} \
-          && composer update ${{ env.COMPOSER_OPTIONS }} \
-          && make build
-
-      - name: Test
-        run: make test-unit && make test-functional
+    name: Tests
+    permissions:
+      contents: read
+    uses: ./.github/workflows/reusable-CI-workflow.yml
@@ -1,57 +1,16 @@
-name: 'Coverage upload'
+name: 'Coverage'
 on:
   workflow_run:
     workflows: ["CI"]
     types: [completed]
 
 jobs:
-  fetch-info:
-    name: Fetch triggering workflow metadata
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      checks: write # For the check run creation !
-    steps:
-      - name: 'Check run ○'
-        uses: yoanm/temp-reports-group-workspace/.github/actions/attach-check-run-to-triggering-workflow-action@develop
-        with:
-          name: 'Fetch coverage info'
-          fails-on-triggering-workflow-failure: true
-
-      - uses: yoanm/temp-reports-group-workspace/.github/actions/fetch-workflow-metadata-action@develop
-        id: fetch-workflow-metadata
-
-    outputs:
-      commit-sha: ${{ steps.fetch-workflow-metadata.outputs.commit-sha }}
-      run-id: ${{ steps.fetch-workflow-metadata.outputs.run-id }}
-
-  codacy-uploader:
-    name: Codacy
-    needs: [fetch-info]
-    uses: yoanm/temp-reports-group-workspace/.github/workflows/codacy-upload-from-artifacts.yml@develop
-    permissions:
-      contents: read
-      checks: write # For the check run creation !
-    secrets:
-      PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }}
-    with:
-      artifacts-pattern: coverage-groups-*
-      run-id: ${{ needs.fetch-info.outputs.run-id }}
-
-  codecov-uploader:
-    name: Codecov
-    needs: [fetch-info]
-    uses: yoanm/temp-reports-group-workspace/.github/workflows/codecov-upload-from-artifacts.yml@develop
+  upload:
+    name: Upload
     permissions:
       contents: read
       checks: write # For the check run creation !
     secrets:
-      TOKEN: ${{ secrets.CODECOV_TOKEN }}
-    with:
-      artifacts-pattern: coverage-groups-*
-      run-id: ${{ needs.fetch-info.outputs.run-id }}
-      override-commit: ${{ needs.fetch-info.outputs.commit-sha }}
-      override-branch: ${{ needs.fetch-info.outputs.branch }}
-      override-pr: ${{ needs.fetch-info.outputs.pr-number }}
-      override-build: ${{ needs.fetch-info.outputs.run-id }}
-      override-build-url: ${{ needs.fetch-info.outputs.run-url }}
+      CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }}
+      CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+    uses: ./.github/workflows/reusable-coverage-upload-workflow.yml
@@ -0,0 +1,40 @@
+name: 'Test CI updates'
+# [DESCRIPTION]
+# As CI workflow relies on `workflow_run` trigger for upload, this workflow is used in order to ease updates made on
+# CI workflow (or linked workflows/actions). It's kind of pre-check to ensure once updates are merged on main branch,
+# the `workflow_run` workflow execution will behave as expected.
+
+on:
+  pull_request:
+    types:
+      - opened
+      - synchronize
+    branches: [master] # Only for PR targeting master branch
+    paths: # /!\ Duplicate the same list as `on.pull_request.paths-ignore` property value for CI workflow !
+      - '.github/workflows/pre-check-CI-updates.yml' # This workflow
+      - '.github/workflows/CI.yml'
+      - '.github/workflows/coverage-upload.yml'
+      - '.github/workflows/reusable-CI-workflow.yml'
+      - '.github/workflows/reusable-coverage-upload-workflow.yml'
+
+concurrency:
+  group: "${{ github.workflow }}-${{ github.head_ref || github.ref }}"
+  cancel-in-progress: true
+
+jobs:
+  tests:
+    name: Tests
+    permissions:
+      contents: read
+    uses: ./.github/workflows/reusable-CI-workflow.yml
+
+  upload:
+    name: Upload
+    needs: [tests]
+    permissions:
+      contents: read
+      checks: write # For the check run creation !
+    secrets:
+      CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }}
+      CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+    uses: ./.github/workflows/reusable-coverage-upload-workflow.yml