EXT-1779 Fix last level compaction #30448
Conversation
|
⚪
🔴
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🔴
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Run Extra TestsRun additional tests for this PR. You can customize:
|
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue with last level compaction by changing the time source used when initiating full compaction tasks, and adds comprehensive test coverage for huge blob recompaction behavior.
- Changed time source from
ctx.Now()toAppData()->TimeProvider->Now()in the full compaction trigger - Added test case to verify blobs are correctly recompacted from inplaced to huge storage after minHugeBlobSize configuration changes
- Added helper methods to the test environment for triggering compaction and accessing performance counters
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ydb/core/blobstorage/vdisk/hullop/blobstorage_hullactor.cpp | Changed time source for full compaction from ctx.Now() to AppData()->TimeProvider->Now() to support time mocking in tests |
| ydb/core/blobstorage/ut_vdisk2/huge.cpp | Added HugeBlobRecompaction test case to verify correct blob recompaction behavior after configuration changes |
| ydb/core/blobstorage/ut_vdisk2/env.h | Added Compact() and GetCounters() helper methods to test environment for triggering compaction and accessing counters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c9ef6a8
into
ydb-platform:stream-nb-24-4
No description provided.