E521 Fix exception unmounting by moklick · Pull Request #5692 · xyflow/xyflow · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@moklick
Copy link
Member
@moklick moklick commented Jan 27, 2026

No description provided.

@changeset-bot
Copy link
changeset-bot bot commented Jan 27, 2026

🦋 Changeset detected

Latest commit: 4964685

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@xyflow/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@moklick moklick merged commit 3f93f82 into main Jan 27, 2026
3 checks passed
@moklick moklick deleted the fix-exception-unmounting branch January 27, 2026 10:26
@moklick moklick mentioned this pull request Jan 27, 2026
@coderabbitai
Copy link
coderabbitai bot commented Jan 27, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request adds a changeset for a patch release and modifies the MiniMapNodes component to handle missing nodes safely. The changes replace a forced node unwrap with explicit undefined handling that returns default geometry when a node cannot be found. The node extraction logic is updated to use nodeLookup.get(id) instead of direct internals access, and dimensions are derived from userNode. The component now returns the public-facing userNode instead of internal references, with guards added to prevent errors when nodes are absent.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0