fix: skip resize handler updates when DOM node is not visible #5455
Conversation
Prevent unnecessary resize calculations and error messages for invisible elements by checking visibility before processing dimensions
|
Hi @moklick, would love to hear your thoughts on this one. |
|
Hey @Sec-ant , first of all thanks for helping out here :) I need to check if this has any other effects. Are you aware that these updates are only happening when the user resizes the window? |
Apart from window resize events, the |
🦋 Changeset detectedLatest commit: 86e8b49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Another stellar PR, thank you @Sec-ant! I realized the style property was not being propagated correctly in Svelte Flow, so I included it in this PR. |
Prevent unnecessary resize calculations and error messages for invisible elements by checking visibility before processing dimensions.
We use
display:nonein our project to hide a react flow canvas on demand without unmounting or destroying its internal states. This patch prevents unnecessary calculations, and also suppresses the "The React Flow parent container needs a width and a height to render the graph." error message in this case.