Bring pyarray and pytensor up to date with xtensor 0.20.0 #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In xtensor-stack/xtensor@bfa8879 , 3 type aliases introduced to xcontainer_inner_types specialization: * using reference = typename storage_type::reference; * using const_reference = typename storage_type::const_reference; * using size_type = typename storage_type::size_type; They should be added to xtensor-python to keep it working for xtensor 0.20.0.
|
Thanks for this fix! |
|
awesome! |
|
Thanks a lot for accepting this. |
|
Thank you for contributing. we will be pushing out releases very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In xtensor-stack/xtensor@bfa8879 , 3 type aliases introduced to xcontainer_inner_types specialization:
using reference = typename storage_type::reference;using const_reference = typename storage_type::const_reference;using size_type = typename storage_type::size_type;They should be added to xtensor-python to keep it working for xtensor 0.20.0.