Add enum_exists() as well as UnitEnum and BackedEnum interfaces #261
Conversation
Step 1 in forwards compatibility with PHP 8.1 enumerations See https://wiki.php.net/rfc/enumerations
Obviously, since # Patch & compile
thekid@Surface:~/bin/php$ curl https://patch-diff.githubusercontent.com/raw/php/php-src/pull/6489.patch | patch -p1
thekid@Surface:~/bin/php$ make clean && ./buildconf && ./config.nice && make
# ...
# Verify enum support is available
thekid@Surface:~/bin/php$ ./sapi/cli/php -r 'enum SortOrder { case ASC; case DESC; } var_dump(SortOrder::ASC);'
enum(SortOrder::ASC)
# Run tests
thekid@Surface:[...]/devel/xp/core$ XP_RT=master xp xp.unittest.Runner src/test/config/unittest/core.ini
Uncaught exception: ParseError (syntax error, unexpected token "enum", expecting identifier)
at <source> [line 10 of ./src/main/php/lang/Enum.class.php]
# ...We would need to rename the Enum class to XPEnum (following the XPClass idiom). We should be able to do this BC break free for PHP 7 and PHP 8.0 by aliasing |
We've actually changed this recently to ease migration. https://wiki.php.net/rfc/enumerations
So your class name should not break. |
Should also be done in unittest library one XP core is released with this change!
There is a glitch in this implementation, @iluuu1994: # Works as expected
thekid@Surface:~/bin/php$ ./sapi/cli/php -r 'class Enum { }'
# Breaks
thekid@Surface:~/bin/php$ ./sapi/cli/php -r 'interface Value { } class Enum implements Value { }'
Parse error: syntax error, unexpected token "enum", expecting identifier in Command line code on line 1`This is the trick you're referencing: /*
* The enum keyword must be followed by whitespace and another identifier.
* This avoids the BC break of using enum in classes, namespaces, functions and constants.
*/
<ST_IN_SCRIPTING>"enum"{WHITESPACE}[a-zA-Z_\x80-\xff] {
yyless(4);
RETURN_TOKEN_WITH_IDENT(T_ENUM);
}The problem is that in |
|
Oh right, thanks for the heads up. Glad you tested that. |
|
@thekid Pushed a fix, does this resolve the problem? |
Yes, it does: # After applying the newer patch:
thekid@Surface:~/bin/php$ ./sapi/cli/php -r 'interface Value { } class Enum implements Value { } var_dump(new Enum());'
object(Enum)#1 (0) {
}Thanks @iluuu1994 ☀ |
|
Great! Thanks for testing 🙂 |
Test resultsPHP 8.0: $ XP_RT=8.0 xp test src/test/php/net/xp_framework/unittest/core/EnumTest.class.php
# ...
♥: 41/45 run (4 skipped), 41 succeeded, 0 failed
Memory used: 2335.88 kB (2544.44 kB peak)
Time taken: 0.079 secondsPHP 8.1 with enums: $ XP_RT=master xp xp.unittest.Runner src/test/php/net/xp_framework/unittest/core/EnumTest.class.php
# ...
♥: 45/45 run (0 skipped), 45 succeeded, 0 failed
Memory used: 2250.23 kB (2646.16 kB peak)
Time taken: 0.065 seconds |
Forwards compatibility with PHP 8.1 enumerations
enum_exists()functionUnitEnumandBackedEnuminterfacesXPClass::isEnum()to also recognize PHP 8.1 enumsEnum::valuesOf()andEnum::valuesOf()to return PHP 8.1 enum casesSee https://wiki.php.net/rfc/enumerations