8000 ENH: Compatible with scikit-learn 1.3.1 by ChengjieLi28 · Pull Request #715 · xorbitsai/xorbits · GitHub
[go: up one dir, main page]

Skip to content

ENH: Compatible with scikit-learn 1.3.1 #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

ChengjieLi28
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Sep 22, 2023
@XprobeBot XprobeBot added this to the v0.6.3 milestone Sep 22, 2023
@codecov
Copy link
codecov bot commented Sep 22, 2023

Codecov Report

Merging #715 (e2bed65) into main (4132deb) will increase coverage by 6.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
+ Coverage   86.55%   93.53%   +6.97%     
==========================================
  Files        1025     1025              
  Lines       79374    79373       -1     
  Branches    16443    16443              
==========================================
+ Hits        68704    74241    +5537     
+ Misses       9116     3445    -5671     
- Partials     1554     1687     +133     
Flag Coverage Δ
unittests 93.42% <ø> (+6.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/xorbits/_mars/learn/neighbors/base.py 96.58% <ø> (+82.99%) ⬆️

... and 113 files with indirect coverage changes

Copy link
Contributor
@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 384e453 into xorbitsai:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0