[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): hightlight dropzone when dragging over it #301

Merged
merged 1 commit into from
May 19, 2019

Conversation

Jefiozie
Copy link
Member

Closes 270

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Small style changes

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behaviour?

A border will be highlighted on dragging, second I removed the white background color.

Screenshot 2019-05-19 at 16 42 08

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@manekinekko manekinekko merged commit 9fde696 into xlayers:master May 19, 2019
@Jefiozie Jefiozie deleted the feature/270 branch May 20, 2019 04:11
shikanime pushed a commit to sfeir-open-source/xlayers that referenced this pull request May 29, 2019
manekinekko pushed a commit that referenced this pull request Oct 17, 2019
* chore: add vue experimental codegen (wip)

* docs: Update README.md (#299)

* fix(editor): icon was not visible for lit Elements (#300)

The icon registered for lit-elements was defined as polymer.
Renamed it to litElement.

* feat(app): hightlight dropzone when dragging over it (#301)

Closes 270

* chore: add blocgen base

* chore: move new codegen to subfolder

* chore: add css parser

* chore: rename root folder

* chore: add Parser options

* chore: add initial vue blocgen

* chore: add edge support for symbolmaster

* chore: separate codegen from parser

* chore: update vue readme

* chore: add tag autoclosing on empty

* fix: xml trailling space blank

* refactor: simplify bitmap ressource format

* fix: css classname property location

* fix: remove autoclose and add undefined css guard

* refactor: merge sketch style parser with blocgen

* fix: orphelin tag

* fix: configuration file not loaded

* chore: switch to blocgen adapter

* chore: conditionnal css output

* chore: add rule to svg

* chore: add text parser

* chore: add frame default css

* fix: join text array

* chore: move css class definition to css parser service

* refactor: explode blocgen service

* chore: blocgen local reorganisation

* refactor: separate blocgen from main code

* refactor: separate vue compute and render

* chore: remove useless vue import template

* refactor: modernize preview

* chore: add styling optimization

* fix: css optimizer

* fix: css shadow

* fix: blocgen svg and css

* fix: fill quote

* chore: inline shapes and images

* refactor: fix svg blocgen name

* refactor: remove karma files

* style: lint

* refactor: arg order and remove options arg

* chore: remove legacy blocgen

* fix: std blocgen type import path

* fix: libraries types

* fix: lib import

* fix: import path

* fix: integration tests

* fix: remove misssing lib.build.prod

* ci: remove lib.build

* refactor: remove meta editor config

* chore: remove useless properties

* fix: svg position

* chore: remove misplaced files

* refactor: remove inlined svg styles

* refactor: facade blocgen and rename sketch ingestor

* chore: merge layer and symbolMaster preview

* refactor: clean useless previousLayout

* chore: guard against nul currentData

* fix: shape preview

* refactor: remove old resource manager

* chore: clarify std naming

* chore: add symbol master in std

* style: global lint

* fix: missing page wireframe

* test: modernize integration test

* test: modernize e2e

* fix: jest config

* chore: remove useless sketch service test

* fix: test type conflict

* fix: explicit script fail

* chore: remove conditionnal traversing

* chore: add symbol master identifier util

* chore: merge text and bitmap blocgens to stdlib

* fix: symbol import

* chore: rename resource service

* fix: integration snapshot

* chore: add flexible rendering options

* chore: add Angular to blocgen

* chore: add lit and react codegen

* chore: web multi render integration

* chore: standardize name

* refactor: blocgen compute flow

* chore: add layer tools

* chore: change image dataurl to png

* chore: optimize css parser scope

* chore: image lookup return base64 by default

* chore: svg fixed size

* chore: optional svg options

* fix: svg context always true

* chore: remove get to put context

* chore: remove useless angular import

* chore: add xml namespace to web options

* chore: remove useless format service from webblocgen

* chore: ignore page layer from web

* chore: add optional classname generation

* chore: move angular routing template to service class

* chore: reindent stackblitz sample files

* chore: move stackblitz spec

* chore: npm audit fix

* fix: merge conflicts

* fix: typescript transpiler conflict

* chore: drop 50 and 51 version support

* style: global lint

* chore: bump circleci node version

* chore: disable demo list for less than 51

* fix: lint warning

* fix: svg flatmap

* chore: remove old package

* fix: cross app library dependency

* fix: circular deps

* fix: useless circular import

* core: fix package references

* chore: replace build by makefile

* fix: layer tree layout wireframe

* chore: remove deprecated rules

* refactor: list join to template

* chore: app build use makefile

* chore: update webblocgen context parsing

* fix: undefined stencil page

* fix: webrender html to string

* style: global lint

* fix: e2e tests

* fix: update test snapshot

* fix: editorconfig makefile indent

* chore: remove karma test

* chore: revert vscode setting

* chore: cleanup package css blocgen

* refactor: rename currentfile to currentdata

* refactor: rename sketchutil to sketchlib

* refactor: rename tag to group

* refactor: remove useless codecomponent oninit

* fix: add traversing to default web render

* style: lint web blocgen

* chore: remove missplaced quote

* fix: symbol tag

* chore: improve template

* chore: prestart hook

* chore: add make to build command

* chore: separate web parser from render

* chore: improve code templating

* fix: svg missing indent

* revert:  closure compiler annotate

* fix: block instead of text tag

* refactor: standardize code structure

* fix: uninterpreted react css import

* fix: missing oval

* revert: remove div class on text

* chore: xamarin svg compat bridge

* chore: remove default context behavior

* fix: templating

* chore: comment integration example

* fix: missing classname

* fix: image export

* fix: null context

* chore: remove web type block

* refactor: layer naming consistency

* refactor: remove useless prividers

* chore: add peer dependencies

* chore: rename render

* refactor: rename blocgen to codegen

* refactor: move xamarin codegen

* feat(landing-page): updated the landing page screenshots (#313)

Updated the screenshots on the landing page and the pointers.

Closes: #312

* fix(parser): pdf parsing at first (#324)

Change parsing pdf at first because of changes in sketch file

Closes #321, #323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants