do not force_ndarray_like #234
Conversation
|
Thanks for opening this @burnpanck . I notice in That seems odd in that it doesn't fully decouple the tests from the code, and also seems like it might be making this PR misleading by causing tests to pass in the CI that would not work in user code? |
|
Didn't spot that one. However, the tests still pass on my machine. To me, this suggests that |
|
As I pointed out in #216 (comment), it is possible to use After changing the unit registry of these tests to have |
I'll have to process that. I'm wondering why one should be using |
|
|
|
I would like to pick this up again. In our company, we have internal libraries that depend on Because of our experience with that and the precedent of |
|
| # make sure scalars are converted to 0d arrays so quantities can | ||
| # always be treated like ndarrays |
There was a problem hiding this comment.
Isn't this comment should be modified as well?
|
for anyone interested in this, please check out the quantity API standardization efforts, which should allow for a cleaner separation between scalar quantities and array quantities. |
force_ndarray_like = True#216pre-commit run --all-fileswhats-new.rst