Vectorized grouped (nan)quantile #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b5ad13 to
5cca384
Compare
11cdc5e to
44c496c
Compare
|
Just saw this in the release notes — very nice! Always feel free to ping numbagg if you want anything like this in there. (also nice to have it without numba though...) |
|
It's all vectorized so I'm not sure there's that much benefit. There might be some for the |
Yes agree... And numba is slower than numpy on sorting! |
I have learned that intel engineers show up to optimize numpy's sorting with all kinds of SIMD tricks, so that's perhaps not so surprising: e.g. numpy/numpy#25045 |
|
Nice!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.