use engine flox for ordered groups #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
reviewed
Oct 2, 2023
There was a problem hiding this comment.
Thanks for working on this!
so the engine detection should be done in a separate function and then we can test this function
Yes!
I only determine the engine in groupby_reduce however it is already accessed in xarray_reduce - this is not optimal (see below)
Yes a helper function will fix this. xarray_reduce can jsut call that.
flox/core.py
Outdated
| @@ -1755,7 +1755,7 @@ def groupby_reduce( | |||
| dtype: np.typing.DTypeLike = None, | |||
| min_count: int | None = None, | |||
| method: T_Method = "map-reduce", | |||
| engine: T_Engine = "numpy", | |||
| engine: T_Engine = None, | |||
There was a problem hiding this comment.
Needs a docstring update.
flox/xarray.py
Outdated
| @@ -72,7 +72,7 @@ def xarray_reduce( | |||
| fill_value=None, | |||
| dtype: np.typing.DTypeLike = None, | |||
| method: str = "map-reduce", | |||
| engine: str = "numpy", | |||
| engine: str = None, | |||
There was a problem hiding this comment.
Again needs docstring update.
|
Thanks for the feedback. I have to let this rest until I find some time again - so feel free to take this over if anyone is interested. |
* upstream/main: Support quantile, median, mode with method="blockwise". (xarray-contrib#269) Add multidimensional binning demo (xarray-contrib#203) [pre-commit.ci] pre-commit autoupdate (xarray-contrib#268) Drop python 3.8, test python 3.11 (xarray-contrib#209) tests: move xfail out of functions (xarray-contrib#265) Bump actions/checkout from 3 to 4 (xarray-contrib#267)
* upstream/main: Add engine="numbagg" (xarray-contrib#72)
* main: repo-review comments (xarray-contrib#270)
|
I hardly qualify to be on here 😅 thanks for finishing up - this will be a huge win! |
dcherian
added a commit
that referenced
this pull request
Nov 3, 2023
* main: (24 commits) Add `packaging` as dependency use engine flox for ordered groups (#266) Update pyproject.toml: py3.12 Bump numpy to >=1.22 (#278) Cleanups (#276) benchmarks updates (#273) repo-review comments (#270) Significantly faster cohorts detection. (#272) Add engine="numbagg" (#72) Support quantile, median, mode with method="blockwise". (#269) Add multidimensional binning demo (#203) [pre-commit.ci] pre-commit autoupdate (#268) Drop python 3.8, test python 3.11 (#209) tests: move xfail out of functions (#265) Bump actions/checkout from 3 to 4 (#267) convert datetime: micro-optimizations (#261) compatibility with `numpy>=2.0` (#257) replace the deprecated `provision-with-micromamba` with `setup-micromamba` (#258) Fix some typing errors in asv_bench and tests (#253) [pre-commit.ci] pre-commit autoupdate (#250) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
engine=Noneand selectengine="flox"for ordered groups. Some commentsgroupby_reducehowever it is already accessed inxarray_reduce- this is not optimal (see below)flox/flox/xarray.py
Line 367 in 5ea713e