forked from symfony/symfony
-
Notifications
You must be signed in to change notification settings - Fork 0
Created ArgumentResolverInterface #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
src/Symfony/Component/HttpKernel/Controller/ArgumentResolverInterface.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\HttpKernel\Controller; | ||
|
||
/** | ||
* An ArgumentResolverInterface implementation resolves the arguments of | ||
* controllers. | ||
* | ||
* @author Wouter J <wouter@wouterj.nl> | ||
*/ | ||
interface ArgumentResolverInterface | ||
{ | ||
/** | ||
* Checks if the current parameter can be resolved by this argument | ||
* resolver. | ||
* | ||
* @param \ReflectionParameter $parameter | ||
* | ||
* @return Boolean | ||
*/ | ||
public function supports(\ReflectionParameter $parameter); | ||
|
||
/** | ||
* Resolves the current parameter into an argument. | ||
* | ||
* @param \ReflectionParameter $parameter | ||
* | ||
* @return mixed The resolved argument | ||
*/ | ||
public function resolve(\ReflectionParameter $parameter); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\ReflectionParameter is exactly what you need here, but depending directly on reflection seems a bit off to me. It's very powerful and can be abused. Next to that, the documentation on php.net is minimal. Is perhaps an idea to wrap something around it like with the ParamConverterInterface? Might be a bit easier to unit-test that as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.