[WIP] Refactor to become a PHP CS Fixer implementation #14
Conversation
|
Why are you using the CS-Fixer project as base ? You only use the main Fixer entry point (in a way not needing most of its features) and the AbstractFixer (required because of the usage of Fixer, but not using any of its features actually). Thus, it will be impossible to update your logic to use PHP-CS-Fixer 2.0 (and 1.x won't stay maintained long once 2.0 is ready), as the Fixer will operate on a Btw, your own Tokens implementation is flawed: caching does not work fine as you don't update the cache hash after updating the content in it. And you also have issues with caching (well, maybe not yet reachable because of the previous issue) as you don't ensure that all fixers are avoiding to corrupt the collection (i.e. the altered collection is equivalent to a collection generated for the resulting markup by the lexer). |
This PR was merged into the 2.3 branch. Discussion ---------- Fixes done automatically by the docbot Started working on the docbot again this week and these are the first results (to be honest: I did remove some invalid changes from this PR). You can see the new docbot code (which is far from perfect) in wouterj/docbot#14 | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | - Commits ------- 4dd3b8a Fixes done automatically by the docbot
This has many benefits for the project, as we get a lot of things for free. The downside is that we need a rock solid parser/dumper for reStructured text. It still has edge cases which aren't properly supported.