8000 Updated standards and fixed problems with python 3.8 by Evert-Arends · Pull Request #57 · woocommerce/wc-api-python · GitHub
[go: up one dir, main page]
Skip to content

Updated standards and fixed problems with python 3.8 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2021
Merged

Updated standards and fixed problems with python 3.8 #57

merged 1 commit into from
Mar 13, 2021

Conversation

Evert-Arends
Copy link
Contributor
  • Updated version
  • Removed percentage operator in favor of f-strings
  • Added HTTPBasicAuth to auth for stricter reading
  • Removed python from HTTPBasicAuth header, to make this API work with the latest version of python.

@Evert-Arends
Updated standards and fixed problems with python 3.8
b6d08cf 
- Updated version
- Removed percentage operator in favor of f-strings
- Added HTTPBasicAuth to auth for stricter reading
- Removed python from HTTPBasicAuth header, to make this API work with the latest version of python.
@Evert-Arends Evert-Arends mentioned this pull request Oct 8, 2020
Closed
@Evert-Arends Evert-Arends mentioned this pull request Jan 6, 2021
Closed
claudiosanches
claudiosanches reviewed Mar 3, 2021
View reviewed changes
Copy link
Contributor
@claudiosanches claudiosanches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like unit test aren't working anymore for older versions of Python.
Still not sure if we could drop support for those.
Thanks for your help.

@Evert-Arends
Copy link
Contributor Author

I do think support for python2.7 should be dropped, as python2.7 is not supported anymore.

However for python 3.5 this could be used: https://stackoverflow.com/questions/55182209/f-string-invalid-syntax-in-python-3-5

You could technically remove the fstring for string format, but that is less future proof.

Thanks for taking a look at this.

Best regards

@claudiosanches
Copy link
Contributor

@Evert-Arends I agree with you, let's set only what is currently supported by Python only.

claudiosanches
claudiosanches approved these changes Mar 13, 2021
View reviewed changes
Copy link
Contributor
@claudiosanches claudiosanches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help, and for inspiring me to drop support to older Python versions.

@claudiosanches claudiosanches merged commit 081b392 into woocommerce:master Mar 13, 2021
@Evert-Arends
Copy link
Contributor Author

Thanks for merging, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiosanches claudiosanches claudiosanches approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Evert-Arends @claudiosanches
0