nodejs-16.yaml: Add openssf-options#32816
Merged
justinvreeland merged 1 commit intowolfi-dev:mainfrom Dec 9, 2024
Merged
Conversation
01ca8bc to
314aa29
Compare
Contributor
|
Gen AI suggestions to solve the build error: • Detected Error: Build failure in V8/ICU compilation with error messages: • Error Category: Build/Dependency • Failure Point: V8 compilation failing due to C++14 standard being used with ICU headers requiring C++17 features • Root Cause Analysis: The build is using C++14 standard ( • Suggested Fix:
- name: Configure and build
runs: |
# Add C++17 flag
export CXXFLAGS="${CXXFLAGS} -std=gnu++17"
# Rest of the existing configure/build commands• Explanation: The ICU library headers are using C++17 features but V8/Node.js is being compiled with C++14. Upgrading to C++17 will provide the required language features needed by ICU while remaining compatible with Node.js 16.x requirements. • Additional Notes:
• References:
|
314aa29 to
d1614ab
Compare
dannf
reviewed
Dec 9, 2024
Member
There was a problem hiding this comment.
Questions inline, but no objection to merging as-is.
dannf
approved these changes
Dec 9, 2024
Member
There was a problem hiding this comment.
At any rate, nothing noted is a regression, so +1
cpanato
pushed a commit
that referenced
this pull request
Dec 23, 2024
A recent fix was added to our node-16 package as part of this PR: - #32816 Believe this should also fix the build error here, so i've ported over the change ----------- <p align="center"> <img src="https://raw.githubusercontent.com/wolfi-dev/.github/b535a42419ce0edb3c144c0edcff55a62b8ec1f8/profile/wolfi-logo-light-mode.svg" /> </p> --------- Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com> Signed-off-by: Mark McCormick <mark.mccormick@chainguard.dev> Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com> Co-authored-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com> Co-authored-by: Mark McCormick <mark.mccormick@chainguard.dev> Co-authored-by: Debasish Biswas <debasishbsws.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.