-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: admin API endpoints to find/remove unmatched stub mappings #2991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: admin API endpoints to find/remove unmatched stub mappings
This integrates the functionality of https://github.com/MasonM/wiremock-unused-stubs-extension into WireMock proper, as requested in #615 (comment). Specifically, it adds two endpoints: * `GET /__admin/mappings/unmatched` - Retrieve stub mappings that haven't matched any requests in the journal. * `DELETE /__admin/mappings/unmatched` - Remove all such stub mappings. Note that the extension supports an additional `?remove_files=1` query parameter that I didn't include here because that introduces some additional complications: https://github.com/MasonM/wiremock-unused-stubs-extension/blob/424dfad1a21e25d588ac9230a46be820a579d7cf/src/main/java/com/github/masonm/wiremock/UnusedStubsAdminExtension.java#L71 I added that feature because it was requested in MasonM/wiremock-unused-stubs-extension#1, though I haven't personally used it much, so I'm not sure if it's worth porting. Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
- Loading branch information
commit 74c40ede5d29edba9081884f1f5054f93c1a43de
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
src/main/java/com/github/tomakehurst/wiremock/admin/tasks/GetUnmatchedStubMappingsTask.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * Copyright (C) 2016-2025 Thomas Akehurst | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.github.tomakehurst.wiremock.admin.tasks; | ||
|
|
||
| import com.github.tomakehurst.wiremock.admin.AdminTask; | ||
| import com.github.tomakehurst.wiremock.admin.model.ListStubMappingsResult; | ||
| import com.github.tomakehurst.wiremock.common.url.PathParams; | ||
| import com.github.tomakehurst.wiremock.core.Admin; | ||
| import com.github.tomakehurst.wiremock.http.ResponseDefinition; | ||
| import com.github.tomakehurst.wiremock.stubbing.ServeEvent; | ||
|
|
||
| public class GetUnmatchedStubMappingsTask implements AdminTask { | ||
|
|
||
| @Override | ||
| public ResponseDefinition execute(Admin admin, ServeEvent serveEvent, PathParams pathParams) { | ||
| ListStubMappingsResult result = admin.findUnmatchedStubs(); | ||
| return ResponseDefinition.okForJson(result); | ||
| } | ||
| } |
31 changes: 31 additions & 0 deletions
31
...ain/java/com/github/tomakehurst/wiremock/admin/tasks/RemoveUnmatchedStubMappingsTask.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /* | ||
| * Copyright (C) 2016-2025 Thomas Akehurst | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.github.tomakehurst.wiremock.admin.tasks; | ||
|
|
||
| import com.github.tomakehurst.wiremock.admin.AdminTask; | ||
| import com.github.tomakehurst.wiremock.common.url.PathParams; | ||
| import com.github.tomakehurst.wiremock.core.Admin; | ||
| import com.github.tomakehurst.wiremock.http.ResponseDefinition; | ||
| import com.github.tomakehurst.wiremock.stubbing.ServeEvent; | ||
|
|
||
| public class RemoveUnmatchedStubMappingsTask implements AdminTask { | ||
|
|
||
| @Override | ||
| public ResponseDefinition execute(Admin admin, ServeEvent serveEvent, PathParams pathParams) { | ||
| admin.findUnmatchedStubs().getMappings().forEach(admin::removeStubMapping); | ||
| return ResponseDefinition.okEmptyJson(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change (and the rest of the changes in this file) are unrelated and the result of running
cd ui && npm run swaggerto regenerate this file, so I assume somebody forgot to do that. Probably should automate that as part of the build process.