8000 Forward command line arguments for console launchers by firai · Pull Request #1569 · winpython/winpython · GitHub
[go: up one dir, main page]
Skip to content

Forward command line arguments for console launchers #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 9, 2025
Merged

Forward command line arguments for console launchers #1569

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5a8a70c
Forward command line arguments in console launcher
firai Apr 25, 2025
042ace7
Handle spaces in launcher path
firai Apr 25, 2025
c4564c0
Fix args test
firai Apr 25, 2025
2684ed0
Replace console launchers
firai Apr 25, 2025
cc06b87
Revert "Replace console launchers"
firai Apr 25, 2025
67e0c4a
Remove extra space from CLI argument
firai Apr 25, 2025
2b5d86e
Remove space from concat rather than from pointer offset
firai Apr 25, 2025
9692aa0
Wrap everything in outer quotes if arguments are passed
firai Apr 25, 2025
3e8c1b4
More reliable way to deal with whitespace
firai Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove extra space from CLI argument
  • Loading branch information
@firai
firai authored Apr 25, 2025
commit 67e0c4a3e09816d42755be785cbeb41862b9cfd3
4 changes: 2 additions & 2 deletions portable/launchers_src/launcher_template_CONSOLE.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ int main() {
if (commandLine[0] == L'"') {
LPWSTR closingQuote = wcschr(commandLine + 1, L'"');
if (closingQuote) {
args = closingQuote + 1; // Skip closing quote and space
args = closingQuote + 2; // Skip closing quote and space
}
// Otherwise skip to first space
} else {
LPWSTR spacePos = wcschr(commandLine, L' ');
if (spacePos) {
args = spacePos + 1; // Skip space
args = spacePos + 2; // GetCommandLineW puts 2 spaces when path isn't double quoted
}
}
}
Expand Down
0