8000 clean-up useless comments by stonebig · Pull Request #1398 · winpython/winpython · GitHub
[go: up one dir, main page]
Skip to content

clean-up useless comments #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2024
Merged

clean-up useless comments #1398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 3 additions & 24 deletions make.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,6 @@ def __init__(
self.flavor = flavor

# python_fname = the .zip of the python interpreter PyPy !
# impot re
# re.match(r'(pypy3*-v|python-)([0-9\.rcba]*)((\.|\-)(amd64|win64)?\.zip')
try: # PyPy
self.python_fname = self.get_package_fname(
r"(pypy3|python-)([0-9]|[a-zA-Z]|.)*.zip"
Expand All @@ -248,16 +246,9 @@ def __init__(
self.python_fname = self.get_package_fname(
r"python-([0-9\.rcba]*)((\.|\-)amd64)?\.(zip|zip)"
)
# osp.join(self.winpydir, self.python_name) = Directory of Python exec
# self.pythondir =osp.join(self.winpydir, self.python_name)
self.python_name = Path(self.python_fname).name[:-4]
self.distname = "winUNKNOWN" # f'win{self.python_name}' # PyPy ?
# vlst = (
# re.match(r'winpython-([0-9\.]*)', self.distname)
# .groups()[0]
# .split('.')
# )
self.python_fullversion = "winUNKNOWN" # '.'.join(vlst[:3])
self.distname = "winUNKNOWN"
self.python_fullversion = "winUNKNOWN"

@property
def package_index_wiki(self):
Expand Down Expand Up @@ -396,19 +387,13 @@ def prepath(self):
def postpath(self):
"""Return PATH contents to be append to the environment variable"""
path = []
# if osp.isfile(self.winpydir + self.THG_PATH):
# path += [r"..\t\TortoiseHg"]
return path

@property
def toolsdirs(self):
"""Return tools directory list"""
# formerly was joining prepared tool dir + the one of building env..
return [
# osp.join(
# osp.dirname(osp.abspath(__file__)), 't'
# )
] + self._toolsdirs
return [] + self._toolsdirs

@property
def docsdirs(self):
Expand Down Expand Up @@ -649,8 +634,6 @@ def _create_launchers(self):
"powershell.ico",
command="Powershell.exe",
args=r"start-process -WindowStyle Hidden -FilePath ([dollar]ENV:WINPYDIRICONS + '\scripts\cmd_ps.bat')",
#command="%WINPYDIRICONS%\\scripts\\cmd_ps.bat",
#args=r"",
)

#self.create_launcher_shimmy(
Expand All @@ -673,8 +656,6 @@ def _create_launchers(self):
"python.ico",
command="Powershell.exe",
args=r"start-process -WindowStyle Hidden -FilePath ([dollar]ENV:WINPYDIRICONS + '\scripts\winidle.bat')",
#command="scripts\\Noshell.vbs scripts\\winidle.bat",
#args=r"",
)

self.create_launcher_shimmy(
Expand Down Expand Up @@ -714,8 +695,6 @@ def _create_launchers(self):
self.create_launcher_shimmy(
"Jupyter Lab.exe",
"jupyter.ico",
#command="$SYSDIR\cmd.exe",
#args=r"/k winjupyter_lab.bat",
command="winjupyter_lab.bat",
args=r"",
workdir=r".\scripts"
Expand Down
0