8000 check and remove osp comments by stonebig · Pull Request #1163 · winpython/winpython · GitHub
[go: up one dir, main page]
Skip to content

check and remove osp comments #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 27, 2022
Merged

check and remove osp comments #1163

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3f25fec
check then cleanup osp comments
stonebig Nov 27, 2022
f65bb6e
check and remove osp comments
stonebig Nov 27, 2022
294a732
check and remove osp comments
stonebig Nov 27, 2022
6a23efd
check and remove osp comments
stonebig Nov 27, 2022
6ac49e8
check and remove osp comments
stonebig Nov 27, 2022
6181721
check and remove osp comments
stonebig Nov 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
check and remove osp comments
  • Loading branch information
@stonebig
stonebig committed Nov 27, 2022
commit 294a7324809581ed18f0d38722f2d1bf3042bbda
4 changes: 0 additions & 4 deletions winpython/qthelpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@

import os
import re
# import os.path as osp
from pathlib import Path
import sys

Expand All @@ -62,7 +61,6 @@

def get_icon(name):
"""Return QIcon from icon name"""
# return QIcon(osp.join(config.IMAGE_PATH, name))
return QIcon(str(Path(config.IMAGE_PATH) / name))


Expand Down Expand Up @@ -157,11 +155,9 @@ def _process_mime_path(path, extlist):
path = path[5:]
else:
path = path[7:]
# if osp.exists(path):
if Path(path).exists():
if (
extlist is None
#or osp.splitext(path)[1] in extlist
or Path(path).suffix in extlist
):
return path
Expand Down
0