8000 update checkout action to latest by faisal · Pull Request #545 · whitesmith/rubycritic · GitHub 8000
[go: up one dir, main page]

Skip to content

Conversation

@faisal
Copy link
Contributor
@faisal faisal commented Dec 4, 2025

Bump the checkout action to v6, as is currently being recommended by Dependabot in other actions. n.b. should we run Dependabot, or will it false positive on too many of our dependencies?

Also, extend our continue-on-error logic to the setup steps, so HEAD and JRuby don't flag red when something breaks on install.

Check list:

@faisal
Copy link
Contributor Author
faisal commented Dec 4, 2025

The HEAD checks are failing because Aruba isn't compatible with Ruby 4. See #546.

@faisal faisal force-pushed the bump_checkout branch 4 times, most recently from 6483eae to 7cfe70e Compare December 4, 2025 12:53
- Update checkout action to v6, as being recommended by Dependabot elsewhere.
- Set continue-on-error to true in setup phases.
@faisal
Copy link
Contributor Author
faisal commented Dec 4, 2025

@etagwerker can you take a look when you get a chance? Note that the HEAD tests all failed, with those results in annotations rather than showing up as failures.

Copy link
Collaborator
@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faisal Looks good, thanks!

@etagwerker etagwerker merged commit 60d1529 into whitesmith:main Dec 5, 2025
26 checks passed
@faisal faisal deleted the bump_checkout branch December 5, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0