8000 Allow notifications and actions to specify a navigable URL by annevk · Pull Request #213 · whatwg/notifications · GitHub
[go: up one dir, main page]
Skip to content

Allow notifications and actions to specify a navigable URL #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 1, 2025
Merged

Allow notifications and actions to specify a navigable URL #213

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
84723c1
Allow notifications and actions to specify a navigable URL
annevk Jul 10, 2024
f4c9633
Update notifications.bs
annevk Nov 7, 2024
2960674
Update notifications.bs
annevk Nov 7, 2024
5946365
address feedback
annevk Jul 31, 2025
9f3359e
ack
annevk Jul 31, 2025
b299868
Update notifications.bs
annevk Jul 31, 2025
80e6695
one more ack
annevk Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address feedback
  • Loading branch information
@annevk
annevk committed Jul 31, 2025
commit 59463650315c26bfa935f95c9b17ab77f788e012
22 changes: 12 additions & 10 deletions notifications.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,16 +577,18 @@ platform supports activation, the user agent must (unless otherwise specified) r
<p>If <var>navigationURL</var> is non-null:

<ol>
<li><p>If there is an existing <a for=/>top-level traversable</a> <var>traversable</var> within
the user agent's <a for="user agent">top-level traversable set</a> whose
<a for="navigable">active document</a>'s <a for=Document>URL</a> <a for=url>equals</a>
<var>navigationURL</var> with <a for=url/equals><i>exclude fragments</i></a> set to true, then
<a for=/>navigate</a> <var>traversable</var> to <var>navigationURL</var> and return. If there are
multiple <a for=/>top-level traversables</a> that satisfy the condition the user agent has to
pick one in an <a>implementation-defined</a> manner.
<!-- Should maybe set userInvolvement correctly here and below. -->

<li><p><a>Create a fresh top-level traversable</a> given <var>navigationURL</var>.
<li>
<p>Select one of the following two options in an <a>implementation-defined</a> manner:

<ul>
<li><p><a for=/>Navigate</a> an existing <a for=/>top-level traversable</a> within the user
agent's <a for="user agent">top-level traversable set</a> to <var>navigationURL</var>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But does Safari actually focus-and-navigate a tab? I think it just focuses a tab and does not navigate per what I see for the non-push external clicks. But I may be wrong.

Also does this need to say about focusing?

Copy link
Member Author
@annevk annevk Jul 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely navigates for me when I follow a link from a different app or run open https://github.com/whatwg/notifications/pull/213. Just lost my initial comment trying that.

<!-- Should maybe set userInvolvement correctly here and below. -->

<li><p><a>Create a fresh top-level traversable</a> given <var>navigationURL</var>.
</ul>

<p class=note>User agents are strongly encouraged to match platform conventions.

<li><p>Return.
</ol>
Expand Down
0