Add pagereveal event
#9818
Merged
Add pagereveal event
#9818
+87
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bokand
reviewed
Oct 20, 2023
smaug----
reviewed
Oct 23, 2023
smaug----
reviewed
Oct 23, 2023
|
@smaug---- @domenic I think this is ready for review, I checked the appropriate boxes. |
domenic
reviewed
Nov 17, 2023
|
@domenic I think this is ready for another run. |
10BC0
domenic
reviewed
Dec 7, 2023
noamr
commented
Dec 8, 2023
domenic
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
LGTM. I did push one more commit to move the event interface back into event interfaces.
Since Gecko has been quite involved in reviewing this, and hasn't yet given a clear "LGTM", I'll give folks like @smaug---- and @zcorpan another day or two to weigh in before we merge. But I agree with your current assessment that there seems to be Gecko support, so unless I hear otherwise I'll default to merging soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
pagerevealevent, and thePageRevealEventinterface.The
pagerevealevent is fired at the beginning of the first rendering opportunity after activation (initial load or reactivation).It is a way for the author to execute some JS that affects the presentation "just in time" for the first frame.
If there is an inbound cross-document view transition, the reveal event holds a reference to the
ViewTransitionobject.Closes #9315.
pagerevealevent mdn/mdn#467(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/index.html ( diff )
/indices.html ( diff )
/infrastructure.html ( diff )
/nav-history-apis.html ( diff )
/webappapis.html ( diff )