10000 Use relevant settings object for pushState/replaceState URL parsing by domenic · Pull Request #1479 · whatwg/html · GitHub
[go: up one dir, main page]
Skip to content

Use relevant settings object for pushState/replaceState URL parsing #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2016
Merged

Use relevant settings object for pushState/replaceState URL parsing #1479

merged 1 commit into from
Jul 6, 2016

Conversation

domenic
Copy link
Member
@domenic domenic commented Jun 30, 2016

Tested by https://url-parsing-entry-iaqyojravh.now.sh/entry/entry.html;
all browsers use relevant, instead of entry, at least for URL parsing.
Further testing is needed for the origin checks.

That test also confirms that window.open() uses entry in all browsers, which is sad :(

Part of #1431.

@domenic
Use relevant settings object for pushState/replaceState URL parsing
13b8769 
Tested by https://url-parsing-entry-iaqyojravh.now.sh/entry/entry.html;
all browsers use relevant, instead of entry, at least for URL parsing.
Further testing is needed for the origin checks.

Part of #1431.
@domenic domenic force-pushed the pushstate-replacestate branch from 71e7d44 to 13b8769 Compare June 30, 2016 22:42
@domenic domenic mentioned this pull request Jun 30, 2016
Open
31 tasks
@annevk annevk merged commit b568cf9 into master Jul 6, 2016
@annevk annevk deleted the pushstate-replacestate branch July 6, 2016 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: multiple globals
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domenic @annevk
0