8000 Integrate Trusted Types enforcement into attribute handling by lukewarlow · Pull Request #1268 · whatwg/dom · GitHub
[go: up one dir, main page]
Skip to content

Integrate Trusted Types enforcement into attribute handling #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 31, 2025
Merged

Integrate Trusted Types enforcement into attribute handling #1268

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
aa3fe7e
Trusted Types
lukewarlow Apr 24, 2025
526f422
Revert change to "set an attribute value"
lukewarlow Apr 24, 2025
00d0eaa
Update setAttributeNS to include TT check
lukewarlow Apr 24, 2025
f5e3984
Remove extra algorithm that called through to TT and call TT directly…
lukewarlow Jun 25, 2025
df2bccd
Revert larger change to setAttributeNs as its no longer neccessary.
lukewarlow Jul 3, 2025
eb1b546
Set attr's value to verifiedValue before attribute change steps are f…
lukewarlow Jul 3, 2025
1e3cef8
Replace this with originalElement inside set an existing attribute value
lukewarlow Sep 30, 2025
6fe40a3
Rename originalElement to just element
lukewarlow Sep 30, 2025
78773d9
Swap element for this in setAttributeNs
lukewarlow Oct 28, 2025
f3148ed
Drop abstract-op and fix associated formatting
lukewarlow Oct 28, 2025
383d39c
Rename tt algorithm
lukewarlow Oct 28, 2025
2075acd
Remove early return when setting an existing attribute value and the …
lukewarlow Oct 30, 2025
1ff8aaa
modernize some of the old prose and lean on early returns
annevk Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Swap element for this in setAttributeNs
  • Loading branch information
@lukewarlow
lukewarlow committed Oct 28, 2025
commit 78773d9f5fe2094a84c161ca93c67808c74372db
2 changes: 1 addition & 1 deletion dom.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7451,7 +7451,7 @@ method steps are:

<li><p>Let <var>verifiedValue</var> be the result of calling <a abstract-op>get
Trusted Types-compliant attribute value</a> with <var>localName</var>, <var>namespace</var>,
<var>element</var>, and <var>value</var>. [[!TRUSTED-TYPES]]
<a>this</a>, and <var>value</var>. [[!TRUSTED-TYPES]]

<li><p><a>Set an attribute value</a> for <a>this</a> using <var>localName</var>,
<var>verifiedValue</var>, and also <var>prefix</var> and <var>namespace</var>.
Expand Down
0