-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with trusted types inside of node conversion #1258
Conversation
Bolt on to #1247 |
@lukewarlow you mentioned somewhere you'd appreciate a review in order to simplify the change. Since it's not primarily about correctness, how helpful would an imminent review be? |
@mbrodesser-Igalia that was for an editorial PR to trusted types (which has been merged) rather than this one, so nothing urgent here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks complicated. Any reason we cannot convert to Text nodes first and then potentially throw for Text nodes if they pose some kind of danger in combination with a script
element?
Ah yeah that's a good idea, can process text nodes and raw strings at the same time them and then can just handle the trusted script after the other processing (because it needs to hold onto the fact it's safe). I knew there was probably a nicer way. |
caa217c
to
77dcd61
Compare
@annevk is there anything left that's needed for this PR? Wanna make sure I'm not holding anything up. |
2210bce
to
1b8e47f
Compare
LGTM @annevk thanks for your help getting this across the line. |
Fixes w3c/trusted-types#438
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff