-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-webkit-background-size has behavioural differences to background-size #28
Comments
Excellent feedback, thanks. |
Should this property always be serialized with two values, so that it can roundtrip with both the prefixed and unprefixed variants? Demo http://software.hixie.ch/utilities/js/live-dom-viewer/saved/7809 Result in chrome
|
FWIW, I regret making the decision to default the second value to @zcorpan Particularly given that single-value syntax isn't the same as doubling it, which is the typical pattern in CSS, serializing as two values feels pretty reasonable here. |
I was reviewing the tests in https://github.com/web-platform-tests/wpt/blob/master/compat/ And it doesn't seem to really work. Safari
Firefox
Chrome
fun! I need to add more tests on the compat tests enumeration to test the behaviors of the values of the properties. |
I'm taking care of this in web-platform-tests/wpt#34493 |
cc @Loirooriol who did work on this in WebKit |
In WebKit gCS should round-trip, so either serialize |
If they're parsed differently, always serializing two values seems better. Is there interest in trying to change the unprefixed property to match the -webkit- prefixed property as @fantasai suggested in #28 (comment) ? |
Should we also change the serialization of |
There are two WPTs that current assume single-value serialization:
I would like to update these tests as part of the WebKit change. @zcorpan @karlcow Do we have consensus from other engines on:
|
I filed an issue for the CSS WG for those questions: w3c/csswg-drafts#7802 |
-webkit-background-size
is listed as a simple alias forbackground-size
when it has different syntactic behaviour.-webkit-background-size: 10px
is equivalent tobackground-size: 10px 10px
.background-size: 10px
is equivalent tobackground-size: 10px auto
(see https://drafts.csswg.org/css-backgrounds-3/#bg-size).The text was updated successfully, but these errors were encountered: