fix: load Cocoa and WebKit frameworks explicitly at runtime #1341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
On one of my macOS builds the linker quietly dropped -framework Cocoa/WebKit, so the runtime never saw classes like NSResponder. When our code called objc_getClass("NSResponder"), it got nil, registered WebviewAppDelegate with no real superclass, and macOS crashed the app as soon as it tried to run +[WebviewAppDelegate initialize].
Change:
I added an ensure_cocoa_frameworks_loaded() helper that dlopens Cocoa and WebKit exactly once, and I call it right at the start of the Cocoa WKWebView backend constructor. That guarantees the frameworks (and their classes) are in memory before we touch any Objective‑C APIs.
Note:
I don't have that much experience in this area and this was the quickest solution i found. So I am happy to hear any feedback.
Greetings Micha