8000 don't suggest 'import exec from ...' by nornagon · Pull Request #62 · webpack-contrib/script-loader · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Nov 5, 2019. It is now read-only.

don't suggest 'import exec from ...' #62

Merged
merged 1 commit into from
Jul 15, 2019
Merged

don't suggest 'import exec from ...' #62

merged 1 commit into from
Jul 15, 2019

Conversation

nornagon
Copy link
Contributor

a) it's unclear what exec means here,
b) at least for me, that syntax generates a confusing error:

TS2306: File '/Users/nornagon/.../my-app/.../script.js' is not a module.

@jsf-clabot
Copy link
jsf-clabot commented Jan 29, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mistic
mistic approved these changes Jan 31, 2019
View reviewed changes
Copy link
@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic
Copy link
mistic commented Jan 31, 2019

@evilebottnawi are u also okay with those changes?

@mistic
Copy link
mistic commented Jul 8, 2019

@evilebottnawi can we merge this?

@mistic mistic merged commit 01f659e into webpack-contrib:master Jul 15, 2019
@alexander-akait
Copy link
Member

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mistic mistic mistic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nornagon @jsf-clabot @mistic @alexander-akait
0