8000 test: pure dep for URL expression by hai-x · Pull Request #19572 · webpack/webpack · GitHub
[go: up one dir, main page]
Skip to content

test: pure dep for URL expression #19572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2025
Merged

test: pure dep for URL expression #19572

merged 1 commit into from
Jun 1, 2025
+56 −0

Conversation

hai-x
Copy link
Member
@hai-x hai-x commented May 30, 2025

What kind of change does this PR introduce?

Add some tests for new URL(expression, import.meta.url). It could be pure when expression is string value.

Please let me know if you have additional test requirements. :)

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

No

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 30, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19572 will degrade performances by 73.2%

Comparing hai-x:test-pure-url (6b71ce3) with main (e805dc1)

Summary

⚡ 80 improvements
❌ 5 regressions
✅ 48 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 11.3 ms 42.3 ms -73.2%
❌ benchmark "devtool-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 37.5 ms 44.9 ms -16.62%
❌ benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 52.1 ms 62.6 ms -16.7%
❌ benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 30.4 ms 34.6 ms -12.24%
❌ benchmark "many-chunks-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 52.5 ms 61.3 ms -14.42%
⚡ md4 buffer benchmark (size: 10000) 114.1 µs 72.8 µs +56.71%
⚡ md4 buffer benchmark (size: 100000) 447.7 µs 406.5 µs +10.12%
⚡ md4 buffer benchmark (size: 120) 76 µs 34.8 µs ×2.2
⚡ md4 buffer benchmark (size: 160) 76 µs 34.9 µs ×2.2
⚡ md4 buffer benchmark (size: 16366) 138.4 µs 97.3 µs +42.3%
⚡ md4 buffer benchmark (size: 16368) 138.5 µs 97.4 µs +42.26%
⚡ md4 buffer benchmark (size: 16370) 138.5 µs 97.3 µs +42.3%
⚡ md4 buffer benchmark (size: 2) 76.3 µs 35.1 µs ×2.2
⚡ md4 buffer benchmark (size: 20) 76.2 µs 32.5 µs ×2.3
⚡ md4 buffer benchmark (size: 200) 76.2 µs 35.1 µs ×2.2
⚡ md4 buffer benchmark (size: 2000) 81.8 µs 40.7 µs ×2
⚡ md4 buffer benchmark (size: 20000) 152.6 µs 111.5 µs +36.88%
⚡ md4 buffer benchmark (size: 2002) 81.8 µs 40.7 µs ×2
⚡ md4 buffer benchmark (size: 40) 73.5 µs 32.5 µs ×2.3
⚡ md4 buffer benchmark (size: 400) 77 µs 35.8 µs ×2.2
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@alexander-akait alexander-akait merged commit fc96903 into webpack:main Jun 1, 2025
43 of 44 checks passed
@hai-x hai-x deleted the test-pure-url branch June 1, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hai-x @alexander-akait
0