8000 fix: sourceTypes of asset module when lazy compilation by hai-x · Pull Request #19539 · webpack/webpack · GitHub
[go: up one dir, main page]
Skip to content

fix: sourceTypes of asset module when lazy compilation #19539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

fix: sourceTypes of asset module when lazy compilation #19539

merged 1 commit into from
May 20, 2025

Conversation

hai-x
Copy link
Member
@hai-x hai-x commented May 16, 2025

What kind of change does this PR introduce?

Fixes #19532.

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

No

@hai-x hai-x force-pushed the fix-asset-type branch from b1c084c to 2accb4b Compare May 16, 2025 13:48
@hai-x
Copy link
Member Author
hai-x commented May 16, 2025

In lib/ModuleTypeConstants.js, we define some module types that are neither javascript/* nor css/*.

To ensure robust module connections, I propose defaulting to JS_TYPES or JS_AND_ASSET_TYPES.

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 16, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19539 will degrade performances by 81.73%

Comparing hai-x:fix-asset-type (2accb4b) with main (843f788)

Summary

⚡ 82 improvements
❌ 4 regressions
✅ 47 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 35.2 ms 42.6 ms -17.27%
⚡ benchmark "devtool-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 11.5 ms 10.4 ms +10.73%
❌ benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 11.3 ms 34.5 ms -67.24%
❌ benchmark "many-chunks-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 11.2 ms 61.4 ms -81.73%
❌ benchmark "many-chunks-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 11.3 ms 61.8 ms -81.64%
⚡ benchmark "react", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 35.1 ms 11.1 ms ×3.2
⚡ md4 buffer benchmark (size: 10000) 114.1 µs 73.1 µs +56.11%
⚡ md4 buffer benchmark (size: 100000) 447.5 µs 406.6 µs +10.04%
⚡ md4 buffer benchmark (size: 120) 75.9 µs 35 µs ×2.2
⚡ md4 buffer benchmark (size: 160) 76.1 µs 35.1 µs ×2.2
⚡ md4 buffer benchmark (size: 16366) 138.5 µs 97.4 µs +42.19%
⚡ md4 buffer benchmark (size: 16368) 138.5 µs 97.5 µs +42.04%
⚡ md4 buffer benchmark (size: 16370) 138.5 µs 97.5 µs +42.1%
⚡ md4 buffer benchmark (size: 2) 76.3 µs 35.1 µs ×2.2
⚡ md4 buffer benchmark (size: 20) 76.4 µs 32.7 µs ×2.3
⚡ md4 buffer benchmark (size: 200) 76.3 µs 35.2 µs ×2.2
⚡ md4 buffer benchmark (size: 2000) 81.9 µs 40.8 µs ×2
⚡ md4 buffer benchmark (size: 20000) 152.7 µs 111.5 µs +36.91%
⚡ md4 buffer benchmark (size: 2002) 81.9 µs 40.8 µs ×2
⚡ md4 buffer benchmark (size: 40) 73.6 µs 32.6 µs ×2.3
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@hai-x hai-x marked this pull request 88C7 as ready for review May 16, 2025 16:21
@alexander-akait alexander-akait merged commit 2c4f967 into webpack:main May 20, 2025
63 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[experiments.lazyCompilation] import()ing asset modules will fail
2 participants
@hai-x @alexander-akait
0