8000 feat: Support VirtualUrlPlugin by xiaoxiaojx · Pull Request #19508 · webpack/webpack · GitHub
[go: up one dir, main page]
Skip to content

feat: Support VirtualUrlPlugin #19508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

feat: Support VirtualUrlPlugin #19508

merged 1 commit into from
May 22, 2025

Conversation

xiaoxiaojx
Copy link
Member

What kind of change does this PR introduce?

feature: Support VirtualUrlPlugin #19458

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

Yes

@xiaoxiaojx xiaoxiaojx mentioned this pull request May 8, 2025
Closed
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19508 will degrade performances by 74.13%

Comparing feat/virtualUrlPlugin (2a578b9) with main (4b309ed)

Summary

⚡ 4 improvements
❌ 1 regressions
✅ 128 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 11.6 ms 44.7 ms -74.13%
⚡ benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 50.1 ms 11.1 ms ×4.5
⚡ benchmark "minimal", scenario '{"name":"mode-development","mode":"development"}' 31.7 ms 24 ms +32.46%
⚡ benchmark "react", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 35.1 ms 31.8 ms +10.53%
⚡ benchmark "three-long", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 224.1 ms 14 ms ×16

@xiaoxiaojx xiaoxiaojx force-pushed the feat/virtualUrlPlugin branch 7 times, most recently from 615c92a to 1b63854 Compare May 9, 2025 14:23
alexander-akait
alexander-akait reviewed May 13, 2025
View reviewed changes
alexander-akait
alexander-akait reviewed May 13, 2025
View reviewed changes
Copy link
Member
@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's add a couple more test cases

@xiaoxiaojx xiaoxiaojx force-pushed the feat/virtualUrlPlugin branch 7 times, most recently from a47c76c to c7cf1da Compare May 17, 2025 15:57
hai-x
hai-x reviewed May 17, 2025
View reviewed changes
@xiaoxiaojx xiaoxiaojx force-pushed the feat/virtualUrlPlugin branch 4 times, most recently from 2e8f410 to f22fb85 Compare May 19, 2025 08:14
alexander-akait
alexander-akait reviewed May 21, 2025
View reviewed changes
@xiaoxiaojx xiaoxiaojx force-pushed the feat/virtualUrlPlugin branch from f22fb85 to 2a578b9 Compare May 22, 2025 03:20
@alexander-akait alexander-akait merged commit e4c21e2 into main May 22, 2025
42 of 44 checks passed
@alexander-akait alexander-akait deleted the feat/virtualUrlPlugin branch May 22, 2025 14:41
@xiaoxiaojx xiaoxiaojx mentioned this pull request May 24, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hai-x hai-x hai-x left review comments

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoxiaojx @alexander-akait @hai-x
0