fix: types of _preWalkVariableDeclaration #19299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
requested changes
Mar 10, 2025
| varDeclarationConst: new HookMap(() => new SyncBailHook(["declaration"])), | ||
| /** @type {HookMap<SyncBailHook<[Declaration], boolean | void>>} */ | ||
| /** @type {HookMap<SyncBailHook<[Pattern], boolean | void>>} */ |
There was a problem hiding this comment.
- I think using
Pattenis a mistake here, maybe we handle very a lot of things and should not do it in such hooks, need investigate
There was a problem hiding this comment.
The hook.call function is accepting the argument of type Pattern though.
decl is actually declarator.id which is also a Pattern -> https://github.com/DefinitelyTyped/DefinitelyTyped/blob/5958465eb0de1b1f305b8d02d343659cb34ea271/types/estree/index.d.ts#L255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds a type to the 2nd parameter of
_preWalkVariableDeclaration. The hook.call function accepts a parameter of typePattern. That's why I thinkPatternwould be a more suitable type thanDeclaration(which is the old one).Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
No