8000 resolving issue #19057 by jalajk3004 · Pull Request #19061 · webpack/webpack · GitHub
[go: up one dir, main page]

Skip to content

resolving issue #19057 #19061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

jalajk3004
Copy link

What kind of change does this PR introduce?

  • This PR introduces a bug fix to improve the handling of dynamic publicPath determination in Webpack.
  • It addresses issues with blob URLs by sanitizing and transforming them for proper resource resolution.

Does this PR introduce a breaking change?
The fix is backward-compatible and enhances Webpack's ability to handle dynamic paths without impacting existing configurations or workflows.

What needs to be documented once your changes are merged?
Update documentation to explain the fallback mechanisms for determining the script URL, including:

  • Support for import.meta.url in module scripts.
  • Fallback to document.currentScript and script tags for non-module scripts.
    Include examples for explicitly setting output.publicPath when needed.

image
I made the changes in the AutoPublicPathRuntimeModule.js

hope this resolves the bug

Copy link
linux-foundation-easycla bot commented Dec 13, 2024

CLA Missing ID CLA Not Signed

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@jalajk3004 jalajk3004 closed this Dec 13, 2024
@alexander-akait
Copy link
Member

@jalajk3004 Please accept CLA

@jalajk3004 jalajk3004 reopened this Dec 13, 2024
@jalajk3004 jalajk3004 closed this Dec 13, 2024
@jalajk3004 jalajk3004 reopened this Dec 13, 2024
@jalajk3004
Copy link
Author

@alexander-akait i have accepted the CLA

@alexander-akait
Copy link
Member

Check your git email

Copy link
Author
@jalajk3004 jalajk3004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait i have created the cla.yml file, and also signed the CLA
074dc7c1-4bee-4662-aa6f-c962f7834bc5.pdf

#custom-pr-sign-comment: 'The signature to be committed in order to sign the CLA'
#custom-allsigned-prcomment: 'pull request comment when all contributors has signed, defaults to **CLA Assistant Lite bot** All Contributors have signed the CLA.'
#lock-pullrequest-aftermerge: false - if you don't want this bot to automatically lock the pull request after merging (default - true)
#use-dco-flag: true - If you are using DCO instead of CLA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@jalajk3004
Copy link
Author

@alexander-akait it would be great if you guide me like what's wrong in the PR or has not the CLA signed yet?
074dc7c1-4bee-4662-aa6f-c962f7834bc5 (1).pdf

@alexander-akait
Copy link
Member
alexander-akait commented Feb 5, 2025

@jalajk3004 Can you provide code where you faced with such problem? We need to add a test case, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0