Add cross-platform readLink method #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this is within scope for this package. At the moment, this package is completely unaware of the filesystem. It only does string manipulation on path strings. This method rather belongs into symfony/filesystem or similar, in my opinion. |
|
I wasn't sure either but I thought as we access environment variables in some methods, it would be fine to access the filesystem. I need this method in the FilesystemRepository tests and I don't want to dupplicate the code. Where do you think I could put this? |
|
I did a PR on symfony/filesystem: symfony/symfony#17498. In the meantime, where could we put this? |
|
The PR was merged: symfony/symfony#17498 |
|
Cool, thanks for the note! :) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For various places in puli/repository (especially FilesystemRepository and its tests), we need to resolve links. For the moment, we have a private method in FilesystemRepository. I propose to add it in path-util as it avoids code dupplication and it let other packages use this. I would use this to fix a part of puli/repository#91.
I'm not sure about the method signature, don't hesitate to tell me what you think :) .