Test all punctiation and whitespace codepoints that should be included in ::first-letter #51361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ea11e7 to
5ff9bcd
Compare
602baa9 to
d7eba4f
Compare
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 11, 2025
… punctuation and letter in ::first-letter range. r=dshin And allow multiple punctuation elements, with potential intervening whitespace, both before and after the letter. Tests to be added once web-platform-tests/wpt#51361 is merged. Differential Revision: https://phabricator.services.mozilla.com/D243674
|
Thanks for doing this. I notice that a bunch of the existing tests (in One thing to note: the spec allows for multiple punctuation codepoints before and/or after the "letter" itself, with potential intervening whitespace (but not word-separator spaces after the letter). It would be good to include a selection of tests for such longer sequences, which I don't think currently have any coverage. E.g. in something (extreme) like my understanding is that everything up to and including the closing parenthesis would be part of ::first-letter. |
d7eba4f to
2a4f932
Compare
…d in ::first-letter
2a4f932 to
49e1b5b
Compare
Good call. 🙏 |
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Apr 16, 2025
… punctuation and letter in ::first-letter range. r=dshin And allow multiple punctuation elements, with potential intervening whitespace, both before and after the letter. Tests to be added once web-platform-tests/wpt#51361 is merged. Differential Revision: https://phabricator.services.mozilla.com/D243674 UltraBlame original commit: a59c7ce8c81e8949b92e606055ae7f58726eba5b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Apr 16, 2025
… punctuation and letter in ::first-letter range. r=dshin And allow multiple punctuation elements, with potential intervening whitespace, both before and after the letter. Tests to be added once web-platform-tests/wpt#51361 is merged. Differential Revision: https://phabricator.services.mozilla.com/D243674 UltraBlame original commit: a59c7ce8c81e8949b92e606055ae7f58726eba5b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Apr 16, 2025
… punctuation and letter in ::first-letter range. r=dshin And allow multiple punctuation elements, with potential intervening whitespace, both before and after the letter. Tests to be added once web-platform-tests/wpt#51361 is merged. Differential Revision: https://phabricator.services.mozilla.com/D243674 UltraBlame original commit: a59c7ce8c81e8949b92e606055ae7f58726eba5b
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Apr 16, 2025
… punctuation and letter in ::first-letter range. r=dshin And allow multiple punctuation elements, with potential intervening whitespace, both before and after the letter. Tests to be added once web-platform-tests/wpt#51361 is merged. Differential Revision: https://phabricator.services.mozilla.com/D243674
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 22, 2025
… punctuation and letter in ::first-letter range. r=dshin And allow multiple punctuation elements, with potential intervening whitespace, both before and after the letter. Tests to be added once web-platform-tests/wpt#51361 is merged. Differential Revision: https://phabricator.services.mozilla.com/D243674
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 22, 2025
…ests that no longer pass. r=jwatt These tests are based on the CSS2 spec for ::first-letter, and no longer match the current CSS Pseudos spec. Once the new and more comprehensive collection of tests in web-platform-tests/wpt#51361 is merged, it would probably make sense to remove these as being obsolete, but for the time being I'm marking them as expected-fail. Differential Revision: https://phabricator.services.mozilla.com/D245359
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Apr 23, 2025
… punctuation and letter in ::first-letter range. r=dshin And allow multiple punctuation elements, with potential intervening whitespace, both before and after the letter. Tests to be added once web-platform-tests/wpt#51361 is merged. Differential Revision: https://phabricator.services.mozilla.com/D243674
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Apr 23, 2025
… punctuation and letter in ::first-letter range. r=dshin And allow multiple punctuation elements, with potential intervening whitespace, both before and after the letter. Tests to be added once web-platform-tests/wpt#51361 is merged. Differential Revision: https://phabricator.services.mozilla.com/D243674
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Apr 23, 2025
…ests that no longer pass. r=jwatt These tests are based on the CSS2 spec for ::first-letter, and no longer match the current CSS Pseudos spec. Once the new and more comprehensive collection of tests in web-platform-tests/wpt#51361 is merged, it would probably make sense to remove these as being obsolete, but for the time being I'm marking them as expected-fail. Differential Revision: https://phabricator.services.mozilla.com/D245359
shtrom
pushed a commit
to mozilla-conduit/ff-test
that referenced
this pull request
Apr 28, 2025
… punctuation and letter in ::first-letter range. r=dshin And allow multiple punctuation elements, with potential intervening whitespace, both before and after the letter. Tests to be added once web-platform-tests/wpt#51361 is merged. Differential Revision: https://phabricator.services.mozilla.com/D243674
shtrom
pushed a commit
to mozilla-conduit/ff-test
that referenced
this pull request
Apr 28, 2025
…ests that no longer pass. r=jwatt These tests are based on the CSS2 spec for ::first-letter, and no longer match the current CSS Pseudos spec. Once the new and more comprehensive collection of tests in web-platform-tests/wpt#51361 is merged, it would probably make sense to remove these as being obsolete, but for the time being I'm marking them as expected-fail. Differential Revision: https://phabricator.services.mozilla.com/D245359
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Apr 29, 2025
… punctuation and letter in ::first-letter range. r=dshin And allow multiple punctuation elements, with potential intervening whitespace, both before and after the letter. Tests to be added once web-platform-tests/wpt#51361 is merged. Differential Revision: https://phabricator.services.mozilla.com/D243674
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Apr 29, 2025
…ests that no longer pass. r=jwatt These tests are based on the CSS2 spec for ::first-letter, and no longer match the current CSS Pseudos spec. Once the new and more comprehensive collection of tests in web-platform-tests/wpt#51361 is merged, it would probably make sense to remove these as being obsolete, but for the time being I'm marking them as expected-fail. Differential Revision: https://phabricator.services.mozilla.com/D245359
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
… punctuation and letter in ::first-letter range. r=dshin And allow multiple punctuation elements, with potential intervening whitespace, both before and after the letter. Tests to be added once web-platform-tests/wpt#51361 is merged. Differential Revision: https://phabricator.services.mozilla.com/D243674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the existing test by testing each punctuation and whitespace character that should be included in the
::first-letterpseudo-element.