8000 Add tests for visibility event sequence in case of back/forward navigation by noamr · Pull Request #31329 · web-platform-tests/wpt · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for visibility event sequence in case of back/forward navigation #31329

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Add tests for visibility event sequence in case of back/forward navigation #31329

merged 3 commits into from
Oct 20, 2021

Conversation

noamr
Copy link
Contributor
@noamr noamr commented Oct 20, 2021 •
edited
Loading

Note that unload events are not tested here, are they're not guaranteed to be fired.

@noamr noamr mentioned this pull request Oct 20, 2021
Merged
1 task
yoavweiss
yoavweiss reviewed Oct 20, 2021
View reviewed changes
page-visibility/iframe-session-history.html Outdated
}]
iframe.src = iframePath1;
document.body.appendChild(iframe);
let sequence = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: ';'

page-visibility/iframe-session-history.html Outdated
}
promise_test(async t => {
const iframe = document.createElement('iframe');
const expected_order = [{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is unused

yoavweiss
yoavweiss approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor
@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noamr noamr merged commit 79e0eba into master Oct 20, 2021
@noamr noamr deleted the pagevis-bf branch October 20, 2021 13:46
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this pull request Nov 18, 2021
@noamr @Gabisampaio
Add tests for visibility event sequence in case of back/forward navig… 7E40
7b61af8 
…ation (web-platform-tests#31329)

* Add tests for visibility event sequence in case of back/forward navigation

* Remove whitespace

* nits

Co-authored-by: Noam Rosenthal <noamr@wix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavweiss yoavweiss yoavweiss approved these changes

@igrigorik igrigorik Awaiting requested review from igrigorik

@plehegar plehegar Awaiting requested review from plehegar

Assignees

@plehegar plehegar

Labels
page-visibility wg-webperf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noamr @yoavweiss @plehegar @wpt-pr-bot
0