[Gecko Bug 1281135] Make <link disabled> work and HTMLLinkElement.disabled reflect that attribute. #16521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttribute. ...instead of forwarding to the sheet like HTMLStyleElement does. I've proposed this behavior in: whatwg/html#3840 (comment) I think this is one of the sane behaviors we can have, what Blink / WebKit do makes no sense to me. Alternative potentially-sane behavior is making the initial value of the stylesheet's disabled bit the same as the content attribute, and both reflect and forward the attribute from the setter. That means that setAttribute does something different than setting `disabled`, which means that you can get into all sorts of funny states when reloading the sheet... So I rather not do that. Differential Revision: https://phabricator.services.mozilla.com/D26573 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1281135 gecko-commit: edbf9758ea946df5063e84c397c43208c555fd74 gecko-integration-branch: central gecko-reviewers: bzbarsky
wpt-pr-bot
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of forwarding to the sheet like HTMLStyleElement does.
I've proposed this behavior in:
whatwg/html#3840 (comment)
I think this is one of the sane behaviors we can have, what Blink / WebKit do
makes no sense to me.
Alternative potentially-sane behavior is making the initial value of the
stylesheet's disabled bit the same as the content attribute, and both reflect
and forward the attribute from the setter.
That means that setAttribute does something different than setting
disabled,which means that you can get into all sorts of funny states when reloading the
sheet... So I rather not do that.
Differential Revision: https://phabricator.services.mozilla.com/D26573
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1281135
gecko-commit: edbf9758ea946df5063e84c397c43208c555fd74
gecko-integration-branch: central
gecko-reviewers: bzbarsky