8000 Aligning spawn timeouts between different functions by networkop · Pull Request #850 · weaveworks/ignite · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Dec 7, 2023. It is now read-only.

Aligning spawn timeouts between different functions #850

Merged
merged 3 commits into from
Jul 5, 2021
Merged

Aligning spawn timeouts between different functions #850

merged 3 commits into from
Jul 5, 2021

Conversation

networkop
Copy link
Contributor
@networkop networkop commented Jun 30, 2021 •
edited
Loading

This PR aligns three timers waiting for spawn startup:

  • Spawn's internal timer waiting for interface to be plugged in
  • waitForSpawn's timer to mark VM as running
  • wautForSSH's timer in run/start.go

darkowlzz
darkowlzz approved these changes Jul 4, 2021
View reviewed changes
Copy link
Contributor
@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement to me.
Thanks.

@networkop @darkowlzz
Update pkg/constants/vm.go
54ea1fb 
Co-authored-by: Sunny <darkowlzz@protonmail.com>
@darkowlzz darkowlzz merged commit 2dbcdd6 into weaveworks:main Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkowlzz darkowlzz darkowlzz approved these changes

@chanwit chanwit Awaiting requested review from chanwit chanwit is a code owner

@luxas luxas Awaiting requested review from luxas

@stealthybox stealthybox Awaiting requested review from stealthybox

@twelho twelho Awaiting requested review from twelho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@networkop @darkowlzz
0