8000 Add Golangci-lint and fix errors by darkowlzz · Pull Request #640 · weaveworks/ignite · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Dec 7, 2023. It is now read-only.

Add Golangci-lint and fix errors #640

Merged
merged 5 commits into from
Jul 20, 2020
Merged

Add Golangci-lint and fix errors #640

merged 5 commits into from
Jul 20, 2020

Conversation

darkowlzz
Copy link
Contributor

Adds golangci-lint github action.

@darkowlzz darkowlzz added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 12, 2020
@darkowlzz darkowlzz requested a review from stealthybox as a code owner July 12, 2020 13:21
darkowlzz
darkowlzz commented Jul 12, 2020
View reviewed changes
darkowlzz
darkowlzz commented Jul 12, 2020
View reviewed changes
darkowlzz added 2 commits July 19, 2020 18:25
@darkowlzz
Temporarily fix pkg/dm errors
9dcf57e 
Golangci-lint run fails due to errors in pkg/dm even if pkg/dm is
added in skip-dirs. The skip is a lint skip, the go code must be valid.
@darkowlzz
Add golangci.yml and fix lint errors
ea71893
@darkowlzz
Add golangci-lint github action
2538007 
Due to the size of the repo, lint run fails after a minute, the
default timeout. Pass --timeout argument to increase the run timeout.
luxas
luxas approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor
@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
one minor nit only

twelho
twelho approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor
@twelho twelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 some more fixes and cleanups coming in a follow-up PR.

@stealthybox stealthybox merged commit afdf7a4 into weaveworks:master Jul 20, 2020
@darkowlzz darkowlzz deleted the golangci-lint branch July 20, 2020 15:53
@darkowlzz darkowlzz mentioned this pull request Jul 26, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luxas luxas luxas approved these changes

@twelho twelho twelho approved these changes

@stealthybox stealthybox Awaiting requested review from stealthybox

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
42D6
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darkowlzz @luxas @twelho @stealthybox
0