8000 Add variation of ring-codec assoc-conj by jconti · Pull Request #87 · weavejester/medley · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@jconti
Copy link
@jconti jconti commented Jan 23, 2024

Implements a variation on ring-codec's assoc-conj.

Resolves #86

@weavejester
Copy link
Owner

I'm in two minds about this one. It could be useful, but I worry it's too specific. You should also change the vector? check to coll? so it works with other collections, and get to find so it works with nil values.

@jconti
Copy link
Author
jconti commented Apr 5, 2024

I'm in two minds about this one. It could be useful, but I worry it's too specific. You should also change the vector? check to coll? so it works with other collections, and get to find so it works with nil values.

Thanks for the patience in getting back to this. I completely agree. Your suggestions did not occur to me, and seem obvious in retrospect. Thank you! Uncertain if this will improve it enough, but I will make these changes so it can be evaluated further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggested addition: assoc-conj

2 participants

0