8000 Code: Exposure of Synchronous Lines by alex-ppg · Pull Request #100 · wcoder/highlightjs-line-numbers.js · GitHub
[go: up one dir, main page]
Skip to content

Code: Exposure of Synchronous Lines #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

Code: Exposure of Synchronous Lines #100

merged 1 commit into from
Oct 11, 2024

Conversation

alex-ppg
Copy link
Contributor

As the title says, I want to expose lineNumbersInternal as it represents the synchronous version of lineNumbersBlock. I believe there are valid use cases whereby the line-by-line mutation on the DOM should happen synchronously. The dist file needs to be updated accordingly.

@realwugang
Copy link

@wcoder

@wcoder wcoder changed the base branch from master to dev October 11, 2024 12:41
@wcoder wcoder merged commit 5b290ae into wcoder:dev Oct 11, 2024
wcoder added a commit that referenced this pull request Oct 11, 2024
@wcoder
Rework sync method. #100
f8e23a3
wcoder added a commit that referenced this pull request Oct 13, 2024
@wcoder
feat: Rework sync method. #100
1055cc2
@wcoder
Copy link
Owner
wcoder commented Oct 13, 2024

@realwugang v2.9.0 released

@SrS2225a SrS2225a mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realwugang realwugang realwugang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-ppg @realwugang @wcoder
0