Merge pull request sigmavirus24#247 from davidmoss/develop

sigmavirus24 · sigmavirus24 · commit 71a4eefbeeeb · 2014-05-15T20:52:28.000-05:00
Adding support for calling URL with invalid SSL cert
diff --git a/AUTHORS.rst b/AUTHORS.rst
@@ -62,3 +62,5 @@ Contributors
 - Benjamin Gilbert (@bgilbert)
 
 - Daniel Johnson (@danielj7)
+
+- David Moss (@damoss007)
diff --git a/github3/github.py b/github3/github.py
@@ -1459,10 +1459,14 @@ class GitHubEnterprise(GitHub):
 
     There is no need to provide the end of the url (e.g., /api/v3/), that will
     be taken care of by us.
+    
+    If you have a self signed SSL for your local github enterprise you can 
+    override the validation by passing `verify=False`.
     """
-    def __init__(self, url, login='', password='', token=''):
+    def __init__(self, url, login='', password='', token='', verify=True):
         super(GitHubEnterprise, self).__init__(login, password, token)
         self._session.base_url = url.rstrip('/') + '/api/v3'
+        self._session.verify = verify
 
     def _repr(self):
         return '<GitHub Enterprise [0.url]>'.format(self)
diff --git a/tests/test_github.py b/tests/test_github.py
@@ -1,4 +1,5 @@
 import github3
+
 from tests.utils import (BaseCase, load, mock)
 
 
@@ -852,6 +853,19 @@ def test_pubsubhubbub(self):
         self.mock_assertions()
 
 
+class TestUnsecureGitHubEnterprise(BaseCase):
+    def setUp(self):
+        super(TestUnsecureGitHubEnterprise, self).setUp()
+        self.g = github3.GitHubEnterprise('https://github.example.com:8080/', verify=False)
+    
+    def test_skip_ssl_validation(self):
+        self.response('pull_enterprise')
+        self.g.pull_request('sigmavirus24', 'github3.py', 19)
+        
+        assert False == self.g._session.verify
+        assert self.request.called
+
+
 class TestGitHubStatus(BaseCase):
     def setUp(self):
         super(TestGitHubStatus, self).setUp()
